-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
STY: Add strict=True in zip() in to_dict.py #62589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mroeschke
merged 2 commits into
pandas-dev:main
from
invain01:STY-Enforce-Ruff-rule-B905
Oct 5, 2025
Merged
STY: Add strict=True in zip() in to_dict.py #62589
mroeschke
merged 2 commits into
pandas-dev:main
from
invain01:STY-Enforce-Ruff-rule-B905
Oct 5, 2025
+12
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pre-commit.ci autofix
for more information, see https://pre-commit.ci
mroeschke
mroeschke
approved these changes
Oct 5, 2025
Thanks @invain01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change enforces Ruff rule B905 (
zip-without-explicit-strict) by addingstrict=Trueto allzip()function calls inpandas/core/methods/to_dict.py. This ensures that input iterables are of equal length, preventing silent truncation and potential data inconsistencies.Modified File
pandas/core/methods/to_dict.pySpecific Changes
The following 6
zip()calls were updated to includestrict=True:zip(box_na_values, df.items())→zip(box_na_values, df.items(), strict=True)zip(columns, map(maybe_box_native, row))→zip(columns, map(maybe_box_native, row), strict=True)zip(columns, t)→zip(columns, t, strict=True)zip(df.columns, map(maybe_box_native, t[1:]))→zip(df.columns, map(maybe_box_native, t[1:]), strict=True)zip(columns, t[1:])→zip(columns, t[1:], strict=True)zip(columns, t[1:])→zip(columns, t[1:], strict=True)