-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
BUG: make read_csv read large integers (>64bits) as python integers with C engine #62582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+72
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Alvaro-Kothe
Alvaro-Kothe
changed the title
(削除) BUG: make read_csv read large integers (>64bits) as objects with C engine (削除ここまで)
(追記) BUG: make read_csv read large integers (>64bits) as python strings with C engine (追記ここまで)
Oct 5, 2025
@Alvaro-Kothe
Alvaro-Kothe
changed the title
(削除) BUG: make read_csv read large integers (>64bits) as python strings with C engine (削除ここまで)
(追記) BUG: make read_csv read large integers (>64bits) as python integers with C engine (追記ここまで)
Oct 5, 2025
mroeschke
mroeschke
approved these changes
Oct 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I think this a net improvement in behavior
Thanks @Alvaro-Kothe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
read_csv()fails to detect floats larger than 2.0^64 #51295 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Reading big integers as strings was tested behavior. I am not sure if this change is desired.
Implementation details
When an overflow occurs during integer parsing, instead of reading the data as a string, now reads it as
PyLongObject.