-
-
Notifications
You must be signed in to change notification settings - Fork 19k
BUG: avoid validation error for ufunc with string[python] array #62498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: avoid validation error for ufunc with string[python] array #62498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Would be a nice if this was elif so it could be un-indented one level, but not a big deal.
Thanks @jorisvandenbossche
Owee, I'm MrMeeseeks, Look at me.
There seem to be a conflict, please backport manually. Here are approximate instructions:
- Checkout backport branch and update it.
git checkout 2.3.x
git pull
- Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 52f1aec9fac2f88119b5733acafcbb3efd1570a3
- You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #62498: BUG: avoid validation error for ufunc with string[python] array'
- Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-62498-on-2.3.x
- Create a PR against branch 2.3.x, I would have named this PR:
"Backport PR #62498 on branch 2.3.x (BUG: avoid validation error for ufunc with string[python] array)"
And apply the correct labels and milestones.
Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!
Remember to remove the Still Needs Manual Backport label once the PR gets merged.
If these instructions are inaccurate, feel free to suggest an improvement.
Manual backport -> #62505
Addresses part of #40800, i.e. fixing the plain error when calling a ufunc that does not return string values on a string array/Series.
There are also issues with the resulting dtype (if the ufunc returns object dtype, should we infer the dtype?), but that is left for another issue (that is also less pressing than fixing the raised error)