-
-
Notifications
You must be signed in to change notification settings - Fork 19k
ENH: consistent exception messages for arithmetic #62455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+234
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brainstorming potential improvements to the messages:
- for reversed ops e.g
__rsub__(x, y), we can make the message aboutsub(y, x)instead? - In some places we have "do x instead" in the exception message. We could let the pattern accomodate that by having _supports_foo_op return
tuple[bool, str | None]with the latter being an optional bit to add to the standard exception message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #62423, does not close.
This does not take a stand on whether to support list/tuple in the EA methods. An EA that currently supports it will continue to, likewise for arrays that don't support it.
Not taking that stand limits the amount of de-duplication/centralization we can do. Instead of all the exceptions being raised from unpack_zerodim_and_defer, helpers
ops.get_op_exception_messageandops.get_shape_exception_messageshould at least help us get to consistent messages.I did a pass to try to use these new helpers where relevant, but definitely didn't get them all. I also didn't implement
_supports_(scalar|array)_opyet.Before I go through the tests to update the exception messages, I'd like to get any bikeshedding out of the way about exactly what those messages should say.