-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
Zip Strict specification for pandas/core/internals #62453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zip Strict specification for pandas/core/internals #62453
Conversation
@anthonyspeicher
anthonyspeicher
commented
Sep 25, 2025
- Assists STY: Enforce Ruff rule B905, zip-without-explicit-strict #62434 as part of a larger zip-explicit-strict effort
- Added explicit strict calls to all zip calls within pandas/core/internals, using strict=True and strict=False as needed
- Maintained consistent pandas code style
- All code checks passed.
- Added type annotations
Thanks for the PR @anthonyspeicher, can you update your branch and remove the files that you modified from pyproject.toml?
Lines 435 to 438 in 179258f
Of course, thank you for your help with my first PR! Please let me know if you need anything else on this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if its really necessary strict=False
...flect correct strict designations
Thanks @anthonyspeicher and the review @Alvaro-Kothe
Co-authored-by: Anthony Speicher <anthony@speicher.org>