TST: add fillna test for filling with Categorical #62319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

thaiv28 wants to merge 3 commits into pandas-dev:main

from thaiv28:test-fillna

Open

TST: add fillna test for filling with Categorical #62319

thaiv28 wants to merge 3 commits into pandas-dev:main from thaiv28:test-fillna

+13 −0

Conversation

thaiv28

Copy link

@thaiv28 thaiv28 commented Sep 11, 2025 •

edited

Loading

closes BUG: AssertionError: Did not expect new dtype float64 to equal self.dtype float64. Please report a bug #56329
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.

Added a test to TestFillNA to check that call fillna with a Series of dtype Categorical does not throw an error.

thaiv28 added 3 commits

September 10, 2025 00:37

@thaiv28


 add test for categorical series

1e59742

@thaiv28


 Merge remote-tracking branch 'upstream/main' into test-fillna

7a4123e

@thaiv28


 fix formatting

3bc51e7

rhshadrach

rhshadrach requested changes

Sep 30, 2025

View reviewed changes

Copy link

Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

pandas/tests/frame/methods/test_fillna.py

)

filler = Series(Categorical([10.0, 20.0, 30.0]))

df.fillna({"ints": filler}, inplace=True)

Copy link

Member

@rhshadrach rhshadrach Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you avoid mutating here; when debugging, it can be helpful to have both before and after the operation accessible.

Suggested change

df.fillna({"ints": filler}, inplace=True)

result=df.fillna({"ints": filler})

pandas/tests/frame/methods/test_fillna.py

tm.assert_frame_equal(df.fillna(value=NaT), df)

def test_fillna_with_categorical_series(self):

df = DataFrame(

Copy link

Member

@rhshadrach rhshadrach Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a reference to the issue as a comment on the first line.

# https://github.com/pandas-dev/pandas/issues/56329

@rhshadrach rhshadrach added Missing-data Needs Tests Categorical labels

Sep 30, 2025

Labels

Categorical Missing-data Needs Tests

2 participants

@thaiv28 @rhshadrach

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

TST: add fillna test for filling with Categorical #62319

Are you sure you want to change the base?

TST: add fillna test for filling with Categorical #62319

Conversation

@thaiv28 thaiv28 commented Sep 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

Uh oh!

@rhshadrach rhshadrach Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

@rhshadrach rhshadrach Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

TST: add fillna test for filling with Categorical #62319

Are you sure you want to change the base?

TST: add fillna test for filling with Categorical #62319

Conversation

@thaiv28 thaiv28 commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

Uh oh!

@rhshadrach rhshadrach Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

@rhshadrach rhshadrach Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@thaiv28 thaiv28 commented Sep 11, 2025 •

edited

Loading