Skip to content

TST : Add comprehensive unit tests for tm.shares_memory utility function (GH#55372) #62291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

Aniketsy wants to merge 8 commits into pandas-dev:main

from Aniketsy:test-shares-memory-55372

Open

TST : Add comprehensive unit tests for tm.shares_memory utility function (GH#55372) #62291

Aniketsy wants to merge 8 commits into pandas-dev:main from Aniketsy:test-shares-memory-55372

Conversation

Copy link

Contributor

@Aniketsy Aniketsy commented Sep 8, 2025 •

edited by jbrockmendel

Loading

xref TST: tests for tm.shares_memory #55372 (Replace xxxx with the GitHub issue number)
Tests added and passed if fixing a bug or adding a new feature

The tests cover the currently supported cases: Numpy arrays and RangeIndex
Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thanks!

Aniketsy added 7 commits

August 25, 2025 04:26


 DOC: Clarify list-like vs scalar in Series.eq docstring

761ac0e


 Merge branch 'main' of https://github.com/pandas-dev/pandas

29662c0


 Merge branch 'main' of https://github.com/pandas-dev/pandas


 Add unit tests for tm.shares_memory ( pandas-dev#55372 )

a85ab96


 Remove unrelated changes to pandas/core/series.py

a0769ff


 Add unit tests for tm.shares_memory ( pandas-dev#55372 )

ff3472b


 Add unit tests for tm.shares_memory ( pandas-dev#55372 )

64a2fe3

Copy link

Member

jbrockmendel commented Sep 8, 2025

This is a start, but there are a ton of cases not covered before we can close #55372

jbrockmendel reviewed

View reviewed changes

pandas/tests/util/test_shares_memory.py Outdated

@@ -30,3 +30,18 @@ def test_shares_memory_string():

obj = pd.array(["a", "b"], dtype=pd.ArrowDtype(pa.string()))

assert tm.shares_memory(obj, obj)

# Unit tests for tm.shares_memory (#55372)

Copy link

Member

@jbrockmendel jbrockmendel Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment isnt helpful

Copy link

Contributor Author

@Aniketsy Aniketsy Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will remove this.

Copy link

Contributor Author

Aniketsy commented Sep 8, 2025

I agree that many important cases (like Series, DataFrame, MultiIndex, etc.) are not yet covered due to current implementation limitations.
Please let me know how you’d like to proceed!


 Add unit tests for tm.shares_memory ( pandas-dev#55372 )

92497fb

@simonjayhawkins simonjayhawkins added the Testing label

Copy link

Member

jbrockmendel commented Sep 12, 2025

Edited the OP to reflect that this doesn't close the issue, set the CI to re-run as the failures should be unrelated. ill merge once that comes back green.

jbrockmendel approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants

@Aniketsy @jbrockmendel @simonjayhawkins