-
-
Notifications
You must be signed in to change notification settings - Fork 18.9k
TST: add regression test for GH#54409 (tz-aware NaT indexing with loc) #62245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jbrockmendel Kindly request you to check it :)
@jbrockmendel Its ready for the review!
@skalwaghe-56
skalwaghe-56
force-pushed
the
test-fix-54409
branch
from
September 4, 2025 13:31
ae46324 to
1ffa939
Compare
Hey, @jbrockmendel Rebased and all checks passed!
@jorisvandenbossche
jorisvandenbossche
added
Testing
pandas testing functions or related to the test suite
Indexing
Related to indexing on series/frames, not to indexes themselves
labels
Sep 5, 2025
@jorisvandenbossche Let me know if these changes looks good to you!
@skalwaghe-56
skalwaghe-56
force-pushed
the
test-fix-54409
branch
2 times, most recently
from
September 8, 2025 14:01
00f7437 to
93aef61
Compare
@jorisvandenbossche Kindly request you to check and let me know!
@skalwaghe-56
skalwaghe-56
force-pushed
the
test-fix-54409
branch
4 times, most recently
from
September 9, 2025 10:00
5b7f988 to
6dc98c0
Compare
@skalwaghe-56
skalwaghe-56
force-pushed
the
test-fix-54409
branch
from
September 10, 2025 10:44
6dc98c0 to
704eb8b
Compare
thanks @skalwaghe-56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a regression test for GH#54409, where
.locfailed whenindexing a tz-aware DateTimeIndex with only NaT. The bug is already
fixed on main, and this test ensures it does not regress.