-
-
Notifications
You must be signed in to change notification settings - Fork 18.9k
DOC: Fix linkcode_resolve for inherited properties #62225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+124
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The @inherit_names decorator creates property wrappers at runtime that delegate to the underlying Array class. These wrappers confuse Sphinx's introspection, causing all inherited properties to link to extension.py instead of their actual implementations. We detect this pattern and redirect to the true source location. Fixes pandas-dev#58350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The @inherit_names decorator creates property wrappers at runtime that delegate to the underlying Array class. These wrappers confuse Sphinx's introspection, causing all inherited properties to link to extension.py instead of their actual implementations. We detect this pattern and redirect to the true source location.
Fixes #58350
Description
Fixed the [source] button links for inherited properties (e.g., DatetimeIndex.quarter). Similar issues were found for other decorators (year, month, time, microsecond, etc.), which were incorrectly pointing to extension.py instead of their actual implementations in the Array classes.