-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
TYP: Add ignores for numpy 2.2 updates #61265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merging to get CI to green. The type ignore can be addressed in the future
Owee, I'm MrMeeseeks, Look at me.
There seem to be a conflict, please backport manually. Here are approximate instructions:
- Checkout backport branch and update it.
git checkout 2.3.x
git pull
- Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 adec21f3fa896684cad04ecf1878a9f2492370ea
- You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #61265: TYP: Add ignores for numpy 2.2 updates'
- Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-61265-on-2.3.x
- Create a PR against branch 2.3.x, I would have named this PR:
"Backport PR #61265 on branch 2.3.x (TYP: Add ignores for numpy 2.2 updates)"
And apply the correct labels and milestones.
Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!
Remember to remove the Still Needs Manual Backport label once the PR gets merged.
If these instructions are inaccurate, feel free to suggest an improvement.
* TYP: Add ignores for numpy 2.2 updates * fix tests and plotting * ignore pyright error
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.