-
-
Notifications
You must be signed in to change notification settings - Fork 203
Conversation
...ult_config, then override them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use from flask import Flask here. Long term, maybe DEFAULT_CONFIG should be defined outside Flask so it can be shared more easily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably clean up config keys from here that aren't used anymore or don't change the default.
JamesParrott
commented
Nov 15, 2024
Thanks for the review. I've made the first change to the import. I case sensitive searched for "Flask" and that string only shows up in comments, so from this basic search at least, I couldn't find a clash in the namespace, so I assume the addition to the namespace is fine.
I don't object to cleaning up the keys, but I'd prefer if someone else took that job on. The first time I looked at Quart's source code was Tuesday this week, so I don't yet have enough knowledge of Flask and Quart to say what all the config items do, and which can safely be removed.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #371 without pinning Flask to 3.0.0
pre-commithooks and fix any issues.A three line change, as per the title:
image