-
Notifications
You must be signed in to change notification settings - Fork 56
Parse also Gitlab-MR-closed event #1492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
softwarefactory-project-zuul
merged 4 commits into
packit:main
from
jpopelka:gitlab-mr-close
May 10, 2022
Merged
Parse also Gitlab-MR-closed event #1492
softwarefactory-project-zuul
merged 4 commits into
packit:main
from
jpopelka:gitlab-mr-close
May 10, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
This comment was marked as outdated.
This comment was marked as outdated.
@jpopelka
jpopelka
force-pushed
the
gitlab-mr-close
branch
from
May 9, 2022 08:07
337d7a9 to
c3e3d92
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@jpopelka
jpopelka
force-pushed
the
gitlab-mr-close
branch
from
May 9, 2022 10:21
c3e3d92 to
d6abb29
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@jpopelka
jpopelka
force-pushed
the
gitlab-mr-close
branch
from
May 9, 2022 10:32
d6abb29 to
0cfb347
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@jpopelka
jpopelka
force-pushed
the
gitlab-mr-close
branch
from
May 9, 2022 11:17
0cfb347 to
0e13ee1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
TomasTomecek
TomasTomecek
approved these changes
May 9, 2022
Member
@TomasTomecek
TomasTomecek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol, and I wondered how come it has +297 -56 while it seemed like an easy PR
90% is tech debt, nice! :)
@jpopelka
jpopelka
force-pushed
the
gitlab-mr-close
branch
from
May 9, 2022 15:08
0e13ee1 to
ee42755
Compare
This comment was marked as outdated.
This comment was marked as outdated.
if one wants to use their local base image.
I need this for hardly, where we want to react when a source-git MR gets closed. packit/hardly#62
@jpopelka
jpopelka
force-pushed
the
gitlab-mr-close
branch
from
May 10, 2022 07:37
ee42755 to
1bef28f
Compare
Contributor
Build succeeded.
✔️ pre-commit SUCCESS in 2m 30s
✔️ packit-service-tests SUCCESS in 2m 21s
✔️ packit-service-tests-openshift SUCCESS in 14m 17s
Contributor
Build succeeded (gate pipeline).
✔️ pre-commit SUCCESS in 3m 13s
@softwarefactory-project-zuul
softwarefactory-project-zuul
bot
merged commit May 10, 2022
858f7b0
into
packit:main
softwarefactory-project-zuul bot
added a commit
to packit/hardly
that referenced
this pull request
May 10, 2022
Sync to dist-git MR when source-git MR has been closed or reopened Test on staging - seems to work OK Fixes #35 #47 Merge after packit/packit-service#1492 packit/ogr#714 (probably won't wait for it since it's blocked on Pagure) Reviewed-by: Tomas Tomecek <tomas@tomecek.net> Reviewed-by: Jiri Popelka <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
I need this for hardly, where we want to react when a source-git MR gets closed.