-
Notifications
You must be signed in to change notification settings - Fork 68
verify RPMs using rpminspect #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/f3aeb8af7f7249be9a7a2b86314df7bb
✔️ pre-commit SUCCESS in 2m 04s
✔️ ogr-tests-rpm SUCCESS in 11m 42s
✔️ ogr-tests-pip-deps SUCCESS in 11m 49s
✔️ ogr-reverse-dep-packit-tests SUCCESS in 19m 12s
Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/02f5e1fc141744edb9ce0da63e35e5a9
✔️ pre-commit SUCCESS in 2m 10s
✔️ ogr-tests-rpm SUCCESS in 12m 00s
✔️ ogr-tests-pip-deps SUCCESS in 11m 58s
✔️ ogr-reverse-dep-packit-tests SUCCESS in 20m 41s
mfocko
commented
May 29, 2023
�[33m[10:42:14] [W] [worker_1] [Fedora-38:x86_64:/plans/rpminspect.fedora] Could not find results file 'work-rpminspect.fedorapxjxl6_l/plans/rpminspect.fedora/execute/results.yaml' containing tmt results�[0m
What?
lbarcziova
commented
Jun 1, 2023
/packit-stg test
LecrisUT
commented
Jun 6, 2023
Btw, for rpmlint of both spec and rpm files (rpmlint -r *.rpmlintrc ./*.spec /tmp/*.rpm as it is done downstream) you might need to add a configure file, e.g.:
$ cat packit.toml
Filters = [
"unknown-key",
]
$ rpmlint -c packit.toml -r *.rpmlintrc ./*.spec /tmp/*.rpm
ab93f1b to
abf740a
Compare
Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/5f18be82226b46b081c2d93b8021e1f3
✔️ pre-commit SUCCESS in 2m 06s
✔️ ogr-tests-rpm SUCCESS in 11m 48s
✔️ ogr-tests-pip-deps SUCCESS in 11m 55s
✔️ ogr-reverse-dep-packit-tests SUCCESS in 19m 05s
mfocko
commented
Jun 23, 2023
/packit test
plans/rpminspect-centos.fmf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A simpler one-liner, and then in tests, change the path accordingly. Should be more robust against future environment changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, I think we wanted to avoid downloading the RPMs ourselves and leave this to TF itself, as looking into packit/packit.dev#607
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I understand this. You mean to not use ${PACKIT_COPR_RPMS} or to have them available on TF by default? Would this still be reproducable locally via the testing farm link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just an alternative way how to download RPMs without changing anything else. So we should be fine with this approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, the only downside might be the lack of DNF on some systems.
abf740a to
ce3cc57
Compare
Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/904eb6465f9a433b81d56d912add66ac
❌ pre-commit FAILURE in 39s
❌ ogr-tests-rpm RETRY_LIMIT in 44s
❌ ogr-tests-pip-deps RETRY_LIMIT in 37s
❌ ogr-reverse-dep-packit-tests FAILURE in 46s
Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/4ce13b494a7c46afa1d7bee56a209501
✔️ pre-commit SUCCESS in 1m 39s
❌ ogr-tests-rpm FAILURE in 10m 33s
❌ ogr-tests-pip-deps FAILURE in 10m 49s
✔️ ogr-reverse-dep-packit-tests SUCCESS in 14m 34s
lbarcziova
commented
Jul 18, 2023
recheck
Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/9076304206264bbc81eed7b48d930974
✔️ pre-commit SUCCESS in 1m 45s
❌ ogr-tests-rpm FAILURE in 10m 23s
❌ ogr-tests-pip-deps FAILURE in 10m 24s
✔️ ogr-reverse-dep-packit-tests SUCCESS in 14m 53s
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
TF downloads both RPMs and SRPM (rebuilt by Copr), so we can run rpminspect on all of them in one step.
8ff307c to
e1adbeb
Compare
Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/73856f30f96b45bdaf7ad8df922a0973
✔️ pre-commit SUCCESS in 2m 40s
✔️ ogr-tests-pip-deps SUCCESS in 17m 03s
LecrisUT
commented
Dec 18, 2024
Actually things have evolved a bit here. How about using the packit/tmt-plans repo? https://github.com/packit/tmt-plans/tree/main/plans/rpminspect. Iirc there was an issue with rpminspect on rawhide related to rpminspect itself, but if the current ones are working fine, maybe it is resolved. Alternatively we could work on https://github.com/fedora-ci/rpminspect-pipeline to make it copr compatible, the benefit being that in that case it's the same container that is used in Fedora-CI
Uh oh!
There was an error while loading. Please reload this page.
just verifying packit/packit.dev#607