-
Notifications
You must be signed in to change notification settings - Fork 68
WIP: Add and implement PullRequest.reopen() #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
jpopelka
commented
Apr 29, 2022
recheck
Build failed.
- pre-commit : SUCCESS in 2m 18s
- ogr-tests-rpm : RETRY_LIMIT in 1m 23s
- ogr-tests-pip-deps : FAILURE in 2m 23s
- ogr-reverse-dep-packit-tests : FAILURE in 2m 47s
jpopelka
commented
Apr 29, 2022
I need to look at the Pagure again since the /reopen endpoint doesn't seem to exist in pagure.io or src.fedoraproject.org even it should have been implemented since https://pagure.io/pagure/pull-request/3349
mfocko
commented
May 1, 2022
Pagure API support here: https://pagure.io/pagure/pull-request/5291
jpopelka
commented
May 2, 2022
You're my personal hero, Maťo!
Sync to dist-git MR when source-git MR has been closed or reopened Test on staging - seems to work OK Fixes #35 #47 Merge after packit/packit-service#1492 packit/ogr#714 (probably won't wait for it since it's blocked on Pagure) Reviewed-by: Tomas Tomecek <tomas@tomecek.net> Reviewed-by: Jiri Popelka <None>
This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.
Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.
This is done in order to ensure that open issues are still relevant.
Thank you for your contribution! 🦄 🚀 🤖
(Note: issues labeled with pinned or EPIC are
never marked as stale.)
mfocko
commented
Jul 11, 2022
pinged Pagure side... once again...
mfocko
commented
Aug 19, 2022
Unblocked, not yet deployed
This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.
Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.
This is done in order to ensure that open issues are still relevant.
Thank you for your contribution! 🦄 🚀 🤖
(Note: issues labeled with pinned or EPIC are
never marked as stale.)
mfocko
commented
Oct 30, 2022
Merged on Pagure' side, not yet released neither deployed...
This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.
Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.
This is done in order to ensure that open issues are still relevant.
Thank you for your contribution! 🦄 🚀 🤖
(Note: issues labeled with pinned or EPIC are
never marked as stale.)
jpopelka
commented
Jan 9, 2023
Still waiting for >5.13.3 release
mfocko
commented
Jan 13, 2023
I'm considering finishing this with a local deployment, cause I have a feeling this PR will live longer than all of us...
I'd like to use this functionality in hardly.
http POST https://pagure.io/api/0/ogr-tests/pull-request/16/close 'Authorization:token my-token'still returns"Invalid or expired token..."even I just generated it with all ACLs.In case it works for you, please uncomment the
test_pr_close_reopen()for pagure and generate the response files. Thanks!!RELEASE NOTES BEGIN
PullRequestnow containsreopen()method implemented by its subclasses.RELEASE NOTES END