-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: add event message resources to ModSecurityIIS.dll and resolve "Invalid function" errors (#3408) #3438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+24
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added ModSecurityIISMessage.mc message resource file for event source metadata - Updated Makefile.win to compile .mc to .res resource file and link into ModSecurityIIS.dll - Modified installer.wxs to register event source pointing to ModSecurityIIS.dll
airween
airween
requested changes
Aug 28, 2025
Hi @A13501350,
many thanks for this excellent PR - great description! I added only one note, see above.
Quality Gate Passed Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
airween
airween
approved these changes
Aug 29, 2025
Thanks @A13501350!
@airween
airween
merged commit Aug 29, 2025
f3f00e3
into
owasp-modsecurity:v2/master
82 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
example results
After the fix, event logs now display properly formatted messages:
references