Use long long instead of int for comparison, increment, decrement operations and persistent collections #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Nakaner wants to merge 1 commit into owasp-modsecurity:v2/master

from geofabrik:v2-counters-long-long

Open

Use long long instead of int for comparison, increment, decrement operations and persistent collections #2134

Nakaner wants to merge 1 commit into owasp-modsecurity:v2/master from geofabrik:v2-counters-long-long

Conversation

Nakaner

Copy link

@Nakaner Nakaner commented Jul 17, 2019

We are using ModSecurity at a download service for large files (hundreds of MB to multiple GB) to manage usage quotas (currently the number of connections per IP address). ModSecurity is able to manage traffic quotas by IP address but this is currently limited to 2^31 bytes because the counters are use the int type only. Using 64 bit integers allows to use ModSecurity to enforce traffic quotas beyond 4 GB.

Support for 64 bit integer is lacking in ModSecurity 3 as well. We run version 2 with Apache and this is basically our patch of the Debian package.

@Nakaner


 Use long long instead for comparison, increment, decrement and persis...

bb7c621

...tent collections.
Up to now, all comparison operators (@gt, @lt, @eq, ...), the =+ and =-
operator for setvar, deprecatevar and persistent collections use 32 bit
integers. Using 64 bit integers allows to use ModSecurity to enforce
traffic quotas.