Commit 7bdc3c8

authored

Merge pull request #3220 from eduar-hte/string-null

Creating a std::string with a null pointer is undefined behaviour

2 parents 3a83196 + 30a68de commit 7bdc3c8Copy full SHA for 7bdc3c8

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -333,9 +333,9 @@ class RulesSetProperties {`
`333`	`333`	`case FalseConfigBoolean:`
`334`	`334`	`return "False";`
`335`	`335`	`case PropertyNotSetConfigBoolean:`
	`336`	`+ default:`
`336`	`337`	`return "Not set";`
`337`	`338`	`}`
`338`		`- return NULL;`
`339`	`339`	`}`
`340`	`340`
`341`	`341`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ std::string UrlEncode::url_enc(const char *input,`
`48`	`48`	`len = input_len * 3 + 1;`
`49`	`49`	`d = rval = reinterpret_cast<char *>(malloc(len));`
`50`	`50`	`if (rval == NULL) {`
`51`		`- return NULL;`
	`51`	`+ return {};`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`/* ENH Only encode the characters that really need to be encoded. */`

Comments

(0)