Commit 30a68de

committed

Creating a std::string with a null pointer is undefined behaviour.

- cppreference mentions this about the constructor that receives a const char *: - Constructs the string with the contents initialized with a copy of the null-terminated character string pointed to by s. The length of the string is determined by the first null character. The behavior is undefined if [s, s + Traits::length(s)) is not a valid range (for example, if s is a null pointer). - C++23 introduces a deleted constructor to prevent this in static scenarios, which is how this issue was detected.

1 parent e8db92e commit 30a68deCopy full SHA for 30a68de

File tree

2 files changed

-2

lines changed

headers/modsecurity
- rules_set_properties.h
src/actions/transformations
- url_encode.cc

2 files changed

-2

lines changed

`‎headers/modsecurity/rules_set_properties.h‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -333,9 +333,9 @@ class RulesSetProperties {`
`333`	`333`	`case FalseConfigBoolean:`
`334`	`334`	`return "False";`
`335`	`335`	`case PropertyNotSetConfigBoolean:`
	`336`	`+ default:`
`336`	`337`	`return "Not set";`
`337`	`338`	`}`
`338`		`- return NULL;`
`339`	`339`	`}`
`340`	`340`
`341`	`341`

`‎src/actions/transformations/url_encode.cc‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ std::string UrlEncode::url_enc(const char *input,`
`48`	`48`	`len = input_len * 3 + 1;`
`49`	`49`	`d = rval = reinterpret_cast<char *>(malloc(len));`
`50`	`50`	`if (rval == NULL) {`
`51`		`- return NULL;`
	`51`	`+ return {};`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`/* ENH Only encode the characters that really need to be encoded. */`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 30a68de

File tree

2 files changed

2 files changed

`‎headers/modsecurity/rules_set_properties.h‎`

`‎src/actions/transformations/url_encode.cc‎`

0 commit comments