-
Notifications
You must be signed in to change notification settings - Fork 298
use msc_init to check modsecurity #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
printf is not part of modsecurity, and may not work with -Werror
mikelolasagasti
commented
Feb 11, 2024
This patch is required by downstream Fedora. It is required even if MODSECURITY_LIB and MODSECURITY_INC are set.
Quality Gate Passed Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
@liudongmiao thanks, this is very useful. (I had solved that with a bit similar way in Debian - but this one is more elegant.)
Could you pick up the current status and rebase your tree? It would be nice to run every PR's against our new workflow.
Thanks!
See owasp-modsecurity/ModSecurity-nginx#275. ModSecurity-nginx uses `printf` as part of the nginx configure test. As of GCC 14, this leads to an error during compilation and thus to an error when running `configure` on nginx. This commit works around the issue by patching the `config` file in ModSecurity-nginx with a valid value for.
close as fixed in #352
printf is not part of modsecurity, and may not work with -Werror