Skip to content

Navigation Menu

Sign in
Sign up

Callbacks enhancement - #851

Draft
mcg-web wants to merge 14 commits into
overblog:master from
mcg-web:callbacks-enhancement
Draft

Callbacks enhancement #851
mcg-web wants to merge 14 commits into
overblog:master from
mcg-web:callbacks-enhancement

Conversation

@mcg-web

@mcg-web mcg-web commented May 20, 2021

Copy link
Copy Markdown
Contributor
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no (at least for now)
Tests pass? yes
Documented? todo
Fixed tickets #708
License MIT

This PR is a proposal of how we could move forward for making expression language optional and simplifying config callbacks.

before:

Query:
 type: object
 config:
 fields:
 user:
 type: User
 resolve: '@=query("query")'
User:
 type: object
 config:
 fields:
 name:
 type: String
 description: "the user name"
 friends:
 type: friendConnection
 argsBuilder: "Relay::Connection"
 resolve: '@=query("friends", value, args)'
 friendsForward:
 type: userConnection
 argsBuilder: "Relay::ForwardConnection"
 resolve: '@=resolver("friends", [value, args])'
 friendsBackward:
 type: userConnection
 argsBuilder: "Relay::BackwardConnection"
 resolve: '@=resolver("friends", [value, args])'
friendConnection:
 type: relay-connection
 config:
 nodeType: User
 resolveNode: '@=query("node", value)'
 edgeFields:
 friendshipTime:
 type: String
 resolve: "Yesterday"
 connectionFields:
 totalCount:
 type: Int
 resolve: '@=query("connection")'
userConnection:
 type: relay-connection
 config:
 nodeType: User
 resolveNode: '@=query("node", value)'

after:

Query:
 type: object
 config:
 fields:
 user:
 type: User
 resolver: 'Overblog\GraphQLBundle\Tests\Functional\App\Resolver\ConnectionResolver::resolveQuery'
User:
 type: object
 config:
 fields:
 name:
 type: String
 description: "the user name"
 friends:
 type: friendConnection
 argsBuilder: "Relay::Connection"
 resolver:
 method: 'overblog_graphql.test.resolver.node::friendsResolver'
 friendsForward:
 type: userConnection
 argsBuilder: "Relay::ForwardConnection"
 resolver:
 id: 'overblog_graphql.test.resolver.node'
 method: 'friendsResolver'
 friendsBackward:
 type: userConnection
 argsBuilder: "Relay::BackwardConnection"
 resolver: 'overblog_graphql.test.resolver.node::friendsResolver'
friendConnection:
 type: relay-connection
 config:
 nodeType: User
 resolveNode: '@=query("node", value)'
 edgeFields:
 friendshipTime:
 type: String
 resolver: 
 expression: "'Yesterday'"
 connectionFields:
 totalCount:
 type: Int
 resolver: '@=query("connection")'

mcg-web requested review from Vincz and murtukov May 20, 2021 07:52
Comment thread src/ExpressionLanguage/ExpressionFunction/Security/GetUser.php Outdated
Comment thread src/ExpressionLanguage/ExpressionFunction/Security/IsAnonymous.php Outdated
Comment thread src/ExpressionLanguage/ExpressionFunction/Security/IsRememberMe.php Outdated
mcg-web force-pushed the callbacks-enhancement branch from b99f525 to 4611415 Compare May 23, 2021 21:44
Comment thread src/Config/TypeDefinition.php Outdated
mcg-web changed the base branch from 0.14 to master December 22, 2021 10:17
@mcg-web mcg-web reopened this Dec 22, 2021
Jeremiah VALERIE and others added 14 commits January 5, 2022 18:15
Jeremiah VALERIE
wip
Jeremiah VALERIE
wip
Jeremiah VALERIE
wip
Jeremiah VALERIE
wip
Co-authored-by: Timur Murtukov <murtukov@gmail.com>
Co-authored-by: Timur Murtukov <murtukov@gmail.com>
Co-authored-by: Timur Murtukov <murtukov@gmail.com>
Co-authored-by: Timur Murtukov <murtukov@gmail.com>
Jeremiah VALERIE
Jeremiah VALERIE
Jeremiah VALERIE
Jeremiah VALERIE
wip
Jeremiah VALERIE
Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@murtukov murtukov murtukov left review comments
@Vincz Vincz Awaiting requested review from Vincz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /