Skip to content

Navigation Menu

Sign in
Sign up

Injection of ResolveInfo into auto-guessed & arguments transformer - #728

Open
Vincz wants to merge 2 commits into
overblog:master from
Vincz:special-arguments
Open

Injection of ResolveInfo into auto-guessed & arguments transformer #728
Vincz wants to merge 2 commits into
overblog:master from
Vincz:special-arguments

Conversation

@Vincz

@Vincz Vincz commented Aug 13, 2020

Copy link
Copy Markdown
Contributor
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? yes
License MIT

This PR adds a way to inject the ResolveInfo through the Argument Transformers and will be able to auto-guessed it based on the class GraphQL\Type\Definition\ResolveInfo.

Usage example with auto-guessing:

/**
 * @GQL\Type
 */
class MyType {
 /**
 * @GQL\Field(type="[String]!")
 */
 public function getSomething(int $amount, ResolveInfo $info) {
 ...
 }
}

Usage example with @Arg

/**
 * @GQL\Type
 */
class RootQuery {
 /**
 * @GQL\Field(
 * type="[User]",
 * args={
 * @GQL\Arg(name="ids", type="[Int]"),
 * @GQL\Arg(name="info", type="@info")
 * },
 * resolve="@=call(service('UserRepository').getUser, arguments({ids: '[Int]', info: '@info'}, arg))"
 * )
 */
 public $getUsers;
}

Vincz requested review from mcg-web and murtukov August 13, 2020 11:42

mcg-web commented Aug 13, 2020

Copy link
Copy Markdown
Contributor

hi Vinc with the Resolver definition enhancement #708 this PR could be totally obsolete since the way how resolver works has been completely rewritten to be more like a Symfony Controller. Can we wait until before merging this? So we can make annotations takes benefit of this new feature.

Vincz commented Aug 13, 2020

Copy link
Copy Markdown
Contributor Author

hi Vinc with the Resolver definition enhancement #708 this PR could be totally obsolete since the way how resolver works has been completely rewritten to be more like a Symfony Controller. Can we wait until before merging this? So we can make annotations takes benefit of this new feature.

Yes, you are right, I forgot about it. No problem, we will merge it later only if it is still relevant.
I was also about to work on a way to extend the auto-guessing (to manage case like : #694), but it's the same and will probably not be relevant after the resolver refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@murtukov murtukov Awaiting requested review from murtukov
@mcg-web mcg-web Awaiting requested review from mcg-web

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /