Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixes Maven dependency issues in the OCI Java SDK #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ljnelson wants to merge 3 commits into oracle:master
base: master
Choose a base branch
Loading
from ljnelson:fix-broken-maven-practices

Conversation

Copy link
Member

@ljnelson ljnelson commented Apr 6, 2022
edited
Loading

(I am aware that this project is a target of an opaque software generation process, so creating a PR against generated code, strictly speaking, cannot succeed, and I have no expectation that this would be "merged", since that is a meaningless concept in this repository. I do this here to hopefully illustrate the kinds of changes that need to be made internally in some source control system prior to whatever process it is that ultimately produces the source code found in this Github repository. Hopefully some developer can take the changes and the diffs in this PR and apply them appropriately to whatever internal repository ultimately produces this one.)

This PR:

  • manages dependency versions properly
  • removes useless dependencies
  • removes scopes from <dependencyManagement> children which is an antipattern
  • moves certain dependencies into the projects that actually use them
  • removes various dependency stanzas in subprojects that indicate that the underdocumented Maven dependency management system was not fully understood (understandably!)
  • as a side effect ends up producing a list of external dependencies in the <properties> stanza of the root pom.xml
  • reduces dependencies, i.e. a dependency on foo-client may actually really only need to be a dependency on foo-core

Broadly speaking: the PR implements proper Maven dependency management, which seems to be what was desired throughout the project, while making it exceedingly clear exactly which external libraries are required by exactly which subprojects.

See:

Signed-off-by: Laird Nelson ljnelson@gmail.com

ljnelson added 2 commits April 5, 2022 21:07
Signed-off-by: Laird Nelson <ljnelson@gmail.com>
Signed-off-by: Laird Nelson <ljnelson@gmail.com>
Signed-off-by: Laird Nelson <ljnelson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /