Skip to content

OCPNODE-3880: Add empty CRIOCredentialProviderConfig resource #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

QiWang19 wants to merge 1 commit into openshift:master

from QiWang19:add-empty-criocp-resource

Open

OCPNODE-3880: Add empty CRIOCredentialProviderConfig resource #2711

Changes from all commits

Commits

Show all changes

Select commit

Add empty CRIOCredentialProviderConfig resource

QiWang19 Feb 16, 2026

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

10 changes: 10 additions & 0 deletions ...d-command/empty-resources/0000_05_config-operator_02_criocredentialproviderconfig.cr.yaml

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,10 @@
	apiVersion: config.openshift.io/v1alpha1
	kind: CRIOCredentialProviderConfig
	metadata:
	name: cluster
	annotations:
	include.release.openshift.io/ibm-cloud-managed: "true"
	include.release.openshift.io/self-managed-high-availability: "true"
	release.openshift.io/create-only: "true"
	release.openshift.io/feature-gate: "CRIOCredentialProviderConfig"
Copy link @qodo-code-review qodo-code-review bot Feb 18, 2026 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Action required 1. Novel *feature-gate* annotation on cr `🐞 Bug` `✓ Correctness` The *release.openshift.io/feature-gate* annotation is used here on a CR for the first time in this codebase — every prior usage is exclusively on *kind: CustomResourceDefinition* objects. If CVO does not honor this annotation for non-CRD resources, the CR will be applied on all clusters matching the cluster-profile annotations (ibm-cloud-managed and self-managed-high-availability), including Default feature-set clusters where the *criocredentialproviderconfigs.config.openshift.io* CRD does not exist, causing a CVO error that could degrade the ClusterVersion operator. Agent Prompt ## Issue description The `release.openshift.io/feature-gate` annotation has only ever been applied to `kind: CustomResourceDefinition` objects in this codebase. Applying it to a CR (`kind: CRIOCredentialProviderConfig`) is novel and unverified. If CVO does not honor this annotation for non-CRD resources, the CR will be applied on Default clusters where the CRD does not exist, causing a CVO error. ## Issue Context - The CRIOCredentialProviderConfig CRD exists only for DevPreviewNoUpgrade, TechPreviewNoUpgrade, and CustomNoUpgrade feature sets. - `CRIOCredentialProviderConfig` is in the `disabled` list for Default clusters (`payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml`). - All other CRDs using `release.openshift.io/feature-gate` also carry `release.openshift.io/feature-set`. - No other file in `payload-command/empty-resources/` uses `release.openshift.io/feature-gate`. ## Fix Focus Areas - payload-command/empty-resources/0000_05_config-operator_02_criocredentialproviderconfig.cr.yaml[9-9] `i Copy this prompt and use it to remediate the issue with your preferred AI generation tools`
	spec: {}