Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Comments

OPRUN-4466: Add NewOLMConfigAPI feature gate#2710

Open
anik120 wants to merge 1 commit intoopenshift:master from
anik120:olmv1-broader-feature-gate
Open

OPRUN-4466: Add NewOLMConfigAPI feature gate #2710
anik120 wants to merge 1 commit intoopenshift:master from
anik120:olmv1-broader-feature-gate

Conversation

@anik120
Copy link
Contributor

@anik120 anik120 commented Feb 16, 2026 •
edited
Loading

Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 16, 2026
Copy link

openshift-ci-robot commented Feb 16, 2026 •
edited by openshift-ci bot
Loading

@anik120: This pull request references OPRUN-4466 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 16, 2026

Hello @anik120! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

Copy link

coderabbitai bot commented Feb 16, 2026 •
edited by openshift-ci bot
Loading

📝 Walkthrough

Walkthrough

This change introduces a new feature gate named NewOLMConfigAPI across the codebase. The feature gate is defined in features.go with configuration details including OLM component association, contact person specification, and an enhancement PR reference. The gate is enabled for SelfManaged clusters using DevPreviewNoUpgrade and TechPreviewNoUpgrade settings. Documentation is updated in features.md, and feature gate manifests are modified across multiple configuration files to appropriately enable or disable the feature for different deployment profiles (Hypershift and SelfManagedHA) and Kubernetes distribution types (Default, DevPreviewNoUpgrade, OKD, TechPreviewNoUpgrade).

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The pull request has no description provided by the author, making it impossible to verify that the description relates to the changeset. Add a pull request description explaining the purpose of the NewOLMConfigAPI feature gate addition and how it relates to OPRUN-4466.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: adding the NewOLMConfigAPI feature gate, which is the primary purpose evident across all modified files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into master

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link 

i You are approaching your monthly quota for Qodo. Upgrade your plan

Review Summary by Qodo

Add NewOLMConfigAPI feature gate for OLM configuration API

✨ Enhancement

Grey Divider

Walkthroughs

Description 
• Add NewOLMConfigAPI feature gate definition with OLM component scope
• Enable feature for SelfManaged and preview cluster profiles
• Update feature gate documentation and manifest files
• Register feature gate across all Hypershift and SelfManagedHA profiles
Diagram 
flowchart LR
 A["NewOLMConfigAPI Feature Gate"] -->|defined in| B["features.go"]
 A -->|documented in| C["features.md"]
 A -->|enabled in| D["Hypershift Profiles"]
 A -->|enabled in| E["SelfManagedHA Profiles"]
 D -->|includes| F["Default/DevPreview/TechPreview/OKD"]
 E -->|includes| G["Default/DevPreview/TechPreview/OKD"]
Loading

Grey Divider

File Changes

1. features/features.go ✨ Enhancement +8/-0

Define NewOLMConfigAPI feature gate with metadata

features/features.go

2. features.md 📝 Documentation +1/-0

Add NewOLMConfigAPI to feature matrix documentation

features.md

3. payload-manifests/featuregates/featureGate-Hypershift-Default.yaml ⚙️ Configuration changes +3/-0

Enable NewOLMConfigAPI in Hypershift default profile

payload-manifests/featuregates/featureGate-Hypershift-Default.yaml

(追記) View more (7) (追記ここまで)
4. payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml ⚙️ Configuration changes +3/-0

Enable NewOLMConfigAPI in Hypershift dev preview profile

payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml

5. payload-manifests/featuregates/featureGate-Hypershift-OKD.yaml ⚙️ Configuration changes +3/-0

Enable NewOLMConfigAPI in Hypershift OKD profile

payload-manifests/featuregates/featureGate-Hypershift-OKD.yaml

6. payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml ⚙️ Configuration changes +3/-0

Enable NewOLMConfigAPI in Hypershift tech preview profile

payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml

7. payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml ⚙️ Configuration changes +3/-0

Enable NewOLMConfigAPI in SelfManagedHA default profile

payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml

8. payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml ⚙️ Configuration changes +3/-0

Enable NewOLMConfigAPI in SelfManagedHA dev preview profile

payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml

9. payload-manifests/featuregates/featureGate-SelfManagedHA-OKD.yaml ⚙️ Configuration changes +3/-0

Enable NewOLMConfigAPI in SelfManagedHA OKD profile

payload-manifests/featuregates/featureGate-SelfManagedHA-OKD.yaml

10. payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml ⚙️ Configuration changes +3/-0

Enable NewOLMConfigAPI in SelfManagedHA tech preview profile

payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml

Grey Divider

Qodo Logo

Copy link

openshift-ci-robot commented Feb 16, 2026 •
edited by openshift-ci bot
Loading

@anik120: This pull request references OPRUN-4466 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

EP: openshift/enhancements#1915

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 16, 2026
Copy link
Contributor

openshift-ci bot commented Feb 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link 

i You are approaching your monthly quota for Qodo. Upgrade your plan

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider 

i The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

Copy link
Contributor

openshift-ci bot commented Feb 16, 2026

@anik120: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

reportProblemsToJiraComponent("olm").
contactPerson("anik120").
productScope(ocpSpecific).
enhancementPR("https://github.com/openshift/enhancements/pull/1915").
Copy link
Contributor

@JoelSpeed JoelSpeed Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this initially as DevPreview? We are expecting that tech preview gated features have a merged EP containing the basics for getting the feature to TP, but I see the EP is currently in draft

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoelSpeed actually we've moved that EP out of draft and it's ready for review :) I'm hoping there's enough time for us to get the EP merged and land this in TP in 4.22 (the usual process we've followed for far for all OLMv1 features).

It also doesn't change the API surface for any CRD and doesn't affect any other OCP components, so my guess is the review should not take too long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@everettraven everettraven Awaiting requested review from everettraven

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /