-
Notifications
You must be signed in to change notification settings - Fork 591
Comments
[release-4.21] OCPBUGS-76408: Move DynamicConfigurationManager back to TPNU#2703
[release-4.21] OCPBUGS-76408: Move DynamicConfigurationManager back to TPNU #2703Miciah wants to merge 2 commits intoopenshift:release-4.21 from
Conversation
Revert "OCPBUGS-62987: Move DynamicConfigurationManager back to DevPreview" This reverts commit 25db151. This commit resolves OCPBUGS-67232. https://issues.redhat.com/browse/OCPBUGS-67232
* features/features.go (FeatureGateIngressControllerDynamicConfigurationManager): Add a link to the dynamic-config-manager enhancement proposal PR.
Hello @Miciah! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
openshift-ci-robot
commented
Feb 10, 2026
@Miciah: This pull request references Jira Issue OCPBUGS-76408, which is invalid:
- release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
Details
In response to this:
This is a manual cherry-pick of #2621.
Move DynamicConfigurationManager back to TPNU
Revert "OCPBUGS-62987: Move DynamicConfigurationManager back to DevPreview"
Add link to the dynamic-config-manager EP PR
Add a link to the dynamic-config-manager enhancement proposal PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Important
Review skipped
Auto reviews are limited based on label configuration.
🚫 Review skipped — only excluded labels are configured. (1)
- do-not-merge/work-in-progress
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
- 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
Comment @coderabbitai help to get the list of available commands and usage tips.
openshift-ci-robot
commented
Feb 10, 2026
Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.
For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.
This repository is configured in: LGTM mode
Review Summary by Qodo
Move IngressControllerDynamicConfigurationManager to TechPreviewNoUpgrade
✨ Enhancement
Walkthroughs
Description
• Move IngressControllerDynamicConfigurationManager from DevPreviewNoUpgrade to TechPreviewNoUpgrade • Add enhancement proposal PR link to feature gate definition • Update feature gate manifests to reflect new availability tier
Diagram
flowchart LR
A["IngressControllerDynamicConfigurationManager<br/>Feature Gate"] -->|"Change Tier"| B["DevPreviewNoUpgrade<br/>to<br/>TechPreviewNoUpgrade"]
A -->|"Add Reference"| C["Enhancement PR #1687"]
B -->|"Update"| D["Feature Gate Manifests"]
File Changes
1. features/features.go
✨ Enhancement +2/-2
Add enhancement link and expand feature tier
• Updated FeatureGateIngressControllerDynamicConfigurationManager to enable in both DevPreviewNoUpgrade and TechPreviewNoUpgrade tiers • Replaced legacy enhancement PR placeholder with actual enhancement proposal link to PR #1687
2. features.md
📝 Documentation +1/-1
Update feature gate documentation table
• Moved IngressControllerDynamicConfigurationManager row from DevPreviewNoUpgrade section to TechPreviewNoUpgrade section • Updated feature gate status table to reflect new availability tier
3. payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
⚙️ Configuration changes +3/-3
Move feature to TechPreviewNoUpgrade tier
• Removed IngressControllerDynamicConfigurationManager from DevPreviewNoUpgrade feature list • Added IngressControllerDynamicConfigurationManager to TechPreviewNoUpgrade feature listpayload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
(追記) View more (1) (追記ここまで)
4. payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
⚙️ Configuration changes +3/-3
Move feature to TechPreviewNoUpgrade tier
• Removed IngressControllerDynamicConfigurationManager from DevPreviewNoUpgrade feature list • Added IngressControllerDynamicConfigurationManager to TechPreviewNoUpgrade feature listpayload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
Code Review by Qodo
🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!
Qodo reviewed your code and found no material issues that require reviewi The new review experience is currently in Beta. Learn more
Miciah
commented
Feb 10, 2026
/jira refresh
openshift-ci-robot
commented
Feb 10, 2026
@Miciah: This pull request references Jira Issue OCPBUGS-76408, which is valid. The bug has been moved to the POST state.
7 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.21.z) matches configured target version for branch (4.21.z)
- bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
- release note text is set and does not match the template
- dependent bug Jira Issue OCPBUGS-67232 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
- dependent Jira Issue OCPBUGS-67232 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
- bug has dependents
Requesting review from QA contact:
/cc @ShudiLi
Details
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
ShudiLi
commented
Feb 10, 2026
tested it with 4.21.0-0-2026年02月10日-060753-test-ci-ln-cv0c42k-latest
1.
% oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.21.0-0-2026年02月10日-060753-test-ci-ln-cv0c42k-latest True False 31m Cluster version is 4.21.0-0-2026年02月10日-060753-test-ci-ln-cv0c42k-latest
2.
% oc get featuregates cluster -oyaml | yq ".status.featureGates[0].enabled" | grep IngressControllerDynamicConfigurationManager
- name: IngressControllerDynamicConfigurationManager
3.
% oc -n openshift-ingress get deployment router-default -oyaml | grep -i -A1 -E "ROUTER_MAX_DYNAMIC_SERVERS|ROUTER_BLUEPRINT_ROUTE_POOL_SIZE"
- name: ROUTER_BLUEPRINT_ROUTE_POOL_SIZE
value: "0"
--
- name: ROUTER_MAX_DYNAMIC_SERVERS
value: "1"
4.
% oc get route
NAME HOST/PORT PATH SERVICES PORT TERMINATION WILDCARD
unsec-apach unsec-apach-default.apps.ci-ln-cv0c42k-72292.gcp-2.ci.openshift.org unsec-apach unsec-apach None
5.
% curl http://unsec-apach-default.apps.ci-ln-cv0c42k-72292.gcp-2.ci.openshift.org
It is a test!
6. part of haproxy configuration
cookie b94bb237dc742029fe83e6d395082b86 insert indirect nocache httponly dynamic
server pod:appach-server-66b4878747-p8wdt:unsec-apach:unsec-apach:10.128.2.12:8080 10.128.2.12:8080 cookie c6ea0f2e1a09f7e2f67aeca4419f5e57 weight 1 check inter 5000ms
server pod:appach-server-66b4878747-tx5t5:unsec-apach:unsec-apach:10.131.0.9:8080 10.131.0.9:8080 cookie eadd206292cf783db0230468815a9f81 weight 1 check inter 5000ms
server pod:appach-server-66b4878747-hvs7m:unsec-apach:unsec-apach:10.131.0.12:8080 10.131.0.12:8080 cookie 71fc03c742a6dfc236217921c7bd0fd8 weight 1 check inter 5000ms
dynamic-cookie-key b94bb237dc742029fe83e6d395082b86
server-template _dynamic-pod- 1-1 172.4.0.4:8765 check disabled
ShudiLi
commented
Feb 10, 2026
/label qe-approved
/verified by @ShudiLi
openshift-ci-robot
commented
Feb 10, 2026
@Miciah: This pull request references Jira Issue OCPBUGS-76408, which is valid.
7 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.21.z) matches configured target version for branch (4.21.z)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
- release note text is set and does not match the template
- dependent bug Jira Issue OCPBUGS-67232 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
- dependent Jira Issue OCPBUGS-67232 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
- bug has dependents
Requesting review from QA contact:
/cc @ShudiLi
Details
In response to this:
This is a manual cherry-pick of #2621.
Move DynamicConfigurationManager back to TPNU
Revert "OCPBUGS-62987: Move DynamicConfigurationManager back to DevPreview"
Add link to the dynamic-config-manager EP PR
Add a link to the dynamic-config-manager enhancement proposal PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
openshift-ci-robot
commented
Feb 10, 2026
@ShudiLi: This PR has been marked as verified by @ShudiLi.
Details
In response to this:
/label qe-approved
/verified by @ShudiLi
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
everettraven
commented
Feb 12, 2026
Any particular reason we want to backport TPNU re-enablement for 4.21?
I don't have any problems with it, but it isn't something I see that often. The last time I saw this done was because we planned to backport enablement of a feature by default as well and backported to TPNU first as a way to test that enablement by default wouldn't cause issues.
Miciah
commented
Feb 12, 2026
Any particular reason we want to backport TPNU re-enablement for 4.21?
Some customers have been testing the feature in earlier OpenShift releases. We want to backport TPNU re-enablement in order to avoid confusion and avoid preventing these customers from testing in 4.21. #2552 was only expected to be a temporary measure to reduce noise in techpreview CI jobs, but we missed the window to re-enable before branch cut, thus the backport.
I don't have any problems with it, but it isn't something I see that often. The last time I saw this done was because we planned to backport enablement of a feature by default as well and backported to TPNU first as a way to test that enablement by default wouldn't cause issues.
We are not currently planning to enable this feature by default in 4.21.
@everettraven
everettraven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
openshift-ci-robot
commented
Feb 12, 2026
Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: everettraven
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Details
Needs approval from an approver in each of these files:(削除) OWNERS (削除ここまで)[everettraven]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@Miciah: all tests passed!
Full PR test history. Your PR dashboard.
Details
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
This is a manual cherry-pick of #2621.
Move DynamicConfigurationManager back to TPNU
Revert "OCPBUGS-62987: Move DynamicConfigurationManager back to DevPreview"
Add link to the dynamic-config-manager EP PR
Add a link to the dynamic-config-manager enhancement proposal PR.