Search code, repositories, users, issues, pull requests...

Copy link

Contributor

@bitoku bitoku commented Feb 3, 2026 •

edited by qodo-code-review bot

Loading

User description

Fixes OCPBUGS-74531

In upstream it's been enabled by default since 1.35 (= 4.22).
https://github.com/kubernetes/kubernetes/pull/135195/changes

PR Type

Enhancement

Description

Remove ImageVolume feature gate from codebase
Feature enabled by default in upstream since 1.35
Update feature gate configurations across all profiles
Clean up generated OpenAPI and feature documentation

Diagram Walkthrough

flowchart LR
 A["ImageVolume Feature Gate"] -- "Remove from" --> B["Feature Definitions"]
 A -- "Remove from" --> C["Feature Gate Manifests"]
 A -- "Remove from" --> D["OpenAPI Specs"]
 B --> E["Cleaned Codebase"]
 C --> E
 D --> E

File Walkthrough

Relevant files
Enhancement	2 files features.go `Remove ImageVolume feature gate definition` +0/-8 zz_generated.openapi.go `Update OpenAPI spec removing ImageVolume` +345/-69144
Documentation	1 files features.md `Remove ImageVolume from feature documentation` +0/-1
Configuration changes	8 files featureGate-Hypershift-DevPreviewNoUpgrade.yaml `Remove ImageVolume from Hypershift DevPreview` +0/-3 featureGate-Hypershift-TechPreviewNoUpgrade.yaml `Remove ImageVolume from Hypershift TechPreview` +0/-3 featureGate-Hypershift-OKD.yaml `Remove ImageVolume from Hypershift OKD` +0/-3 featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml `Remove ImageVolume from SelfManagedHA DevPreview` +0/-3 featureGate-SelfManagedHA-OKD.yaml `Remove ImageVolume from SelfManagedHA OKD` +0/-3 featureGate-Hypershift-Default.yaml `Remove ImageVolume from Hypershift Default` +0/-3 featureGate-SelfManagedHA-Default.yaml `Remove ImageVolume from SelfManagedHA Default` +0/-3 featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml `Remove ImageVolume from SelfManagedHA TechPreview` +0/-3

@openshift-ci-robot openshift-ci-robot added jira/valid-reference jira/valid-bug labels

Copy link

openshift-ci-robot commented Feb 3, 2026

@bitoku: This pull request references Jira Issue OCPBUGS-74531, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lyman9966

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fixes OCPBUGS-74531

In upstream it's been enabled by default since 1.35 (= 4.22).
https://github.com/kubernetes/kubernetes/pull/135195/changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci-robot commented Feb 3, 2026

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

Copy link

coderabbitai bot commented Feb 3, 2026 •

edited

Loading

📝 Walkthrough

Walkthrough

This pull request removes the ImageVolume feature from the repository. Changes: deleted the FeatureGateImageVolume declaration in features/features.go, removed the ImageVolume row from features.md, and removed ImageVolume from enabled lists in eight feature-gate manifest files under payload-manifests/featuregates/ (Hypershift and SelfManagedHA across Default, DevPreviewNoUpgrade, TechPreviewNoUpgrade, and OKD).

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: removing the ImageVolume feature gate from the codebase.
Description check	✅ Passed	The description is comprehensive and directly related to the changeset, explaining the rationale, scope, and specific files affected.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

@openshift-ci openshift-ci bot requested a review from lyman9966

February 3, 2026 16:10

Copy link

openshift-ci-robot commented Feb 3, 2026

@bitoku: This pull request references Jira Issue OCPBUGS-74531, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lyman9966

Details

In response to this:

User description

Fixes OCPBUGS-74531

In upstream it's been enabled by default since 1.35 (= 4.22).
https://github.com/kubernetes/kubernetes/pull/135195/changes

PR Type

Enhancement

Description

Remove ImageVolume feature gate from codebase

Feature enabled by default in upstream since 1.35

Update feature gate configurations across all profiles

Clean up generated OpenAPI and feature documentation

Diagram Walkthrough
flowchart LR
 A["ImageVolume Feature Gate"] -- "Remove from" --> B["Feature Definitions"]
 A -- "Remove from" --> C["Feature Gate Manifests"]
 A -- "Remove from" --> D["OpenAPI Specs"]
 B --> E["Cleaned Codebase"]
 C --> E
 D --> E
Loading
File Walkthrough

Relevant files
Enhancement
2 files

features.go
Remove ImageVolume feature gate definition
+0/-8

zz_generated.openapi.go
Update OpenAPI spec removing ImageVolume
+345/-69144

Documentation
1 files

features.md
Remove ImageVolume from feature documentation
+0/-1

Configuration changes
8 files

featureGate-Hypershift-DevPreviewNoUpgrade.yaml
Remove ImageVolume from Hypershift DevPreview
+0/-3

featureGate-Hypershift-TechPreviewNoUpgrade.yaml
Remove ImageVolume from Hypershift TechPreview
+0/-3

featureGate-Hypershift-OKD.yaml
Remove ImageVolume from Hypershift OKD
+0/-3

featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml
Remove ImageVolume from SelfManagedHA DevPreview
+0/-3

featureGate-SelfManagedHA-OKD.yaml
Remove ImageVolume from SelfManagedHA OKD
+0/-3

featureGate-Hypershift-Default.yaml
Remove ImageVolume from Hypershift Default
+0/-3

featureGate-SelfManagedHA-Default.yaml
Remove ImageVolume from SelfManagedHA Default
+0/-3

featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
Remove ImageVolume from SelfManagedHA TechPreview
+0/-3

@qodo-code-review qodo-code-review bot added the Review effort 2/5 label

@qodo-code-review

Copy link

qodo-code-review bot commented Feb 3, 2026 •

edited

Loading

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance

🟢

No security concerns identified

No security vulnerabilities detected by AI analysis. Human verification advised for critical code.

Ticket Compliance

⚪

🎫 No ticket provided

Create ticket/issue

Codebase Duplication Compliance

⚪

Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance

⚪

Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status:
Diff not provided: The PR diff content is not included (no + lines shown), so it cannot be verified whether
any critical actions were added/changed without appropriate audit logging context (user,
timestamp, action, outcome).

Referred Code

package features

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status:
Diff not provided: The PR diff content is not included (no + lines shown), so new/changed identifiers cannot
be reviewed for meaningful naming and self-documenting intent.

Referred Code

package features

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status:
Diff not provided: The PR diff content is not included (no + lines shown), so it cannot be verified whether
new/changed code paths properly handle errors and edge cases with actionable context.

Referred Code

package features

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status:
Diff not provided: The PR diff content is not included (no + lines shown), so it cannot be verified whether
any user-facing errors were introduced/changed to avoid leaking sensitive internal
details.

Referred Code

package features

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status:
Diff not provided: The PR diff content is not included (no + lines shown), so it cannot be verified whether
any new/changed logging is structured and free of sensitive data.

Referred Code

package features

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status:
Diff not provided: The PR diff content is not included (no + lines shown), so it cannot be verified whether
new/changed code introduces external inputs requiring validation/sanitization or impacts
authentication/authorization-sensitive behavior.

Referred Code

package features

Learn more about managing compliance generic rules or creating your own custom rules

Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@openshift-ci

Copy link

Contributor

openshift-ci bot commented Feb 3, 2026

Hello @bitoku! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M label

openapi/generated_openapi/zz_generated.openapi.go [17-19]

@qodo-code-review

Copy link

qodo-code-review bot commented Feb 3, 2026 •

edited

Loading

PR Code Suggestions ✨

Explore these optional code suggestions:

Category

Suggestion

Impact

High-level

Regenerate the incomplete OpenAPI specification

The generated OpenAPI specification file is missing numerous API definitions and
appears incomplete. Regenerate the file using the full code generation process
to ensure its correctness.

Examples:

func GetOpenAPIDefinitions(ref common.ReferenceCallback) map[string]common.OpenAPIDefinition {
	return map[string]common.OpenAPIDefinition{
		"k8s.io/api/admissionregistration/v1.AuditAnnotation": schema_k8sio_api_admissionregistration_v1_AuditAnnotation(ref),

Solution Walkthrough:

Before:

// openapi/generated_openapi/zz_generated.openapi.go
func GetOpenAPIDefinitions(ref common.ReferenceCallback) map[string]common.OpenAPIDefinition {
	return map[string]common.OpenAPIDefinition{
		// ... hundreds of API definitions are missing from the map ...
	}
}

After:

// openapi/generated_openapi/zz_generated.openapi.go
// After running the full code generation `make update`
func GetOpenAPIDefinitions(ref common.ReferenceCallback) map[string]common.OpenAPIDefinition {
	return map[string]common.OpenAPIDefinition{
		"github.com/openshift/api/apps/v1.DeploymentConfig": schema_openshift_api_apps_v1_DeploymentConfig(ref),
		"github.com/openshift/api/authorization/v1.Role": schema_openshift_api_authorization_v1_Role(ref),
		"github.com/openshift/api/build/v1.Build": schema_openshift_api_build_v1_Build(ref),
		"github.com/openshift/api/image/v1.ImageStream": schema_openshift_api_image_v1_ImageStream(ref),
		// ... and hundreds more definitions correctly included
	}
}

Suggestion importance[1-10]: 9

Why: The suggestion correctly identifies that the generated OpenAPI spec file is critically incomplete, which would break API clients and tooling if merged.

High

Update

@openshift-ci openshift-ci bot requested review from JoelSpeed and everettraven

February 3, 2026 16:17

@JoelSpeed

Copy link

Contributor

JoelSpeed commented Feb 3, 2026

Code generation appears to be out of date here, can you please look at the failure in the verify check and regenerate?

@bitoku bitoku force-pushed the remove-imagevolume branch from cb2183f to 6de7126 Compare

February 3, 2026 17:01

@openshift-ci openshift-ci bot added size/XXL and removed size/M labels


 Remove ImageVolume

17ddae3

@bitoku bitoku force-pushed the remove-imagevolume branch from 6de7126 to 17ddae3 Compare

February 3, 2026 17:59

@openshift-ci openshift-ci bot added size/M and removed size/XXL labels

Copy link

Contributor Author

bitoku commented Feb 4, 2026

/retest

@JoelSpeed

Copy link

Contributor

JoelSpeed commented Feb 4, 2026

/lgtm
/pipeline auto
/verified by CI

Assuming E2Es are passing, then that's the complete verification we need

@openshift-ci-robot openshift-ci-robot added the pipeline-auto label

Copy link

openshift-ci-robot commented Feb 4, 2026

Pipeline controller notification

The pipeline-auto label has been added to this PR. Second-stage tests will be triggered automatically when all first-stage tests pass.

@openshift-ci-robot openshift-ci-robot added the verified label

Copy link

openshift-ci-robot commented Feb 4, 2026

@JoelSpeed: This PR has been marked as verified by CI.

Details

In response to this:

/lgtm
/pipeline auto
/verified by CI

Assuming E2Es are passing, then that's the complete verification we need

@openshift-ci openshift-ci bot assigned JoelSpeed

@openshift-ci openshift-ci bot added the lgtm label

@openshift-ci

Copy link

Contributor

openshift-ci bot commented Feb 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~(削除) OWNERS (削除ここまで)~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label

Copy link

openshift-ci-robot commented Feb 4, 2026

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

Copy link

openshift-ci-robot commented Feb 4, 2026

/retest-required

Remaining retests: 0 against base HEAD e09e5a4 and 2 for PR HEAD 17ddae3 in total

Copy link

openshift-ci-robot commented Feb 4, 2026

/retest-required

Remaining retests: 0 against base HEAD 9a67b6d and 1 for PR HEAD 17ddae3 in total

Copy link

openshift-ci-robot commented Feb 4, 2026

/retest-required

Remaining retests: 0 against base HEAD 0acc398 and 0 for PR HEAD 17ddae3 in total

Copy link

openshift-ci-robot commented Feb 4, 2026

/hold

Revision 17ddae3 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold label

Full PR test history. Your PR dashboard.

@openshift-ci

Copy link

Contributor

openshift-ci bot commented Feb 5, 2026

@bitoku: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-hypershift-conformance	`17ddae3`	link	true	`/test e2e-aws-ovn-hypershift-conformance`
ci/prow/e2e-azure	`17ddae3`	link	true	`/test e2e-azure`
ci/prow/e2e-aws-ovn	`17ddae3`	link	true	`/test e2e-aws-ovn`
ci/prow/e2e-aws-ovn-techpreview	`17ddae3`	link	true	`/test e2e-aws-ovn-techpreview`
ci/prow/e2e-gcp	`17ddae3`	link	true	`/test e2e-gcp`

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.