-
Notifications
You must be signed in to change notification settings - Fork 92
test: skip tests #3116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
test: skip tests #3116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
pieh
commented
Sep 11, 2025
Comment on lines
+487
to
491
{
"file": "test/e2e/app-dir/sub-shell-generation-middleware/sub-shell-generation-middleware.test.ts",
"reason": "Checking Vercel specific x-vercel-cache header",
"tests": ["middleware-static-rewrite should eventually result in a cache hit"]
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was recently added
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
pieh
commented
Sep 11, 2025
Comment on lines
+479
to
+486
{
"file": "test/e2e/app-dir/rsc-redirect/rsc-redirect.test.ts",
"reason": "page.waitForLoadState('networkidle') not resolving",
"tests": [
"rsc-redirect /old-about -> /about (ppr: false, segmentCache: true) uses prefetched, redirected URL in the navigation, as opposed to the href in the link",
"rsc-redirect /old-about -> /about (ppr: false, segmentCache: false) uses prefetched, redirected URL in the navigation, as opposed to the href in the link"
]
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test failure or rather timeout is confusing. Test get stuck on
page.waitForLoadState('networkidle')
usage of which is strongly discouraged:
'networkidle' - DISCOURAGED wait until there are no network connections for at least 500 ms. Don't use this method for testing, rely on web assertions to assess readiness instead.
The test does pass if I replace that with couple seconds of just sleeping, but that's not something we can change so skipping it here.
I did try to debug this test on what keeps it stuck, but all the initiated requests finish and I so no network activity that could be keeping it stuck 🤷
pieh
pieh
commented
Sep 11, 2025
mrstork
mrstork
previously approved these changes
Sep 12, 2025
mrstork
mrstork
reviewed
Sep 12, 2025
mrstork
mrstork
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip tests that are checking Vercel specific response header OR ones that previously passed, but no longer do after #3100 excluded lambda from handling 404s for
_next/static