-
Notifications
You must be signed in to change notification settings - Fork 92
fix: support ppr shells for dynamic page routes #3092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@pieh
pieh
added
the
test all versions
Run e2e tests against old and canary versions of Next.js
label
Sep 2, 2025
📊 Package size report 0.04%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
pieh
commented
Sep 2, 2025
@@ -356,7 +359,7 @@ export class PluginContext {
// - `string` - when user use pages router with `fallback: true`, and then it's html file path
// - `null` - when user use pages router with `fallback: 'block'` or app router with `export const dynamicParams = true`
// - `false` - when user use pages router with `fallback: false` or app router with `export const dynamicParams = false`
if (typeof meta.fallback === 'string') {
if (typeof meta.fallback === 'string' && meta.renderingMode !== 'PARTIALLY_STATIC') {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the fix for deploy failures -we tried to treat PPR shells as pages router fallbacks so we later on tried to read contents from server/pages that was leading to ENOENT errors).
The other changes in this PR are to actually support those shells being uploaded to cache and used later on (instead of generating them on-demand later on again in runtime)
@pieh
pieh
changed the title
(削除) fix: support ppr dynamic shells (削除ここまで)
(追記) fix: support ppr shells for dynamic page routes (追記ここまで)
Sep 2, 2025
mrstork
mrstork
previously approved these changes
Sep 2, 2025
mrstork
mrstork
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
We've been treating shells for dynamic ppr page routes as fallbacks for pages router and failing to assemble cache content to upload because of that.
This PR:
Tests
Adjusted PPR fixture to use dynamic page routes and added some assertions making sure thing do work
Relevant links (GitHub issues, etc.) or a picture of cute animal
Fixes #3073
Fixes FRB-1784