-
Notifications
You must be signed in to change notification settings - Fork 92
test: skip more tests that don't exactly match status code due to platform differences #3077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...tform differences
pieh
pieh
commented
Aug 27, 2025
Comment on lines
+416
to
+422
{
"file": "test/e2e/app-dir/actions/app-action-size-limit-invalid-node-middleware.test.ts",
"reason": "Mismatch of reported status code of response (502 instead of expected 500)",
"tests": [
"app-dir action size limit invalid config should respect the size set in serverActions.bodySizeLimit for plaintext fetch actions should error for requests that exceed the size limit",
"app-dir action size limit invalid config should respect the size set in serverActions.bodySizeLimit for multipart fetch actions should error for requests that exceed the size limit"
]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty much the same as previous entry, just this test suite was using node middleware while previous test suite was using edge middleware
FAIL default test/e2e/app-dir/actions/app-action-size-limit-invalid-node-middleware.test.ts (137.775 s)
app-dir action size limit invalid config
should respect the size set in serverActions.bodySizeLimit for plaintext fetch actions
✓ should not error for requests that stay below the size limit (2461 ms)
✕ should error for requests that exceed the size limit (710 ms)
should respect the size set in serverActions.bodySizeLimit for multipart fetch actions
✓ should not error for requests that stay below the size limit (8847 ms)
✓ should not error for requests that are at the size limit (1548 ms)
✕ should error for requests that exceed the size limit (1078 ms)
●くろまる app-dir action size limit invalid config › should respect the size set in serverActions.bodySizeLimit for plaintext fetch actions › should error for requests that exceed the size limit
expect(received).toBe(expected) // Object.is equality
Expected: 500
Received: 502
�[0m �[90m 137 |�[39m { request�[33m:�[39m { method�[33m:�[39m �[32m'POST'�[39m�[33m,�[39m pathname�[33m:�[39m �[32m'/file'�[39m } }
�[90m 138 |�[39m )
�[31m�[1m>�[22m�[39m�[90m 139 |�[39m expect(actionResponse�[33m.�[39mstatus())�[33m.�[39mtoBe(�[35m500�[39m) �[90m// TODO: 413?�[39m
�[90m |�[39m �[31m�[1m^�[22m�[39m
�[90m 140 |�[39m expect(
�[90m 141 |�[39m �[36mawait�[39m actionResponse�[33m.�[39mrequest()�[33m.�[39mheaderValue(�[32m'content-type'�[39m)
�[90m 142 |�[39m )�[33m.�[39mtoStartWith(�[32m'text/plain'�[39m)�[0m
at Object.toBe (e2e/app-dir/actions/app-action-size-limit-invalid.test.ts:139:39)
●くろまる app-dir action size limit invalid config › should respect the size set in serverActions.bodySizeLimit for multipart fetch actions › should error for requests that exceed the size limit
expect(received).toBe(expected) // Object.is equality
Expected: 500
Received: 502
�[0m �[90m 226 |�[39m { request�[33m:�[39m { method�[33m:�[39m �[32m'POST'�[39m�[33m,�[39m pathname�[33m:�[39m �[32m'/form'�[39m } }
�[90m 227 |�[39m )
�[31m�[1m>�[22m�[39m�[90m 228 |�[39m expect(actionResponse�[33m.�[39mstatus())�[33m.�[39mtoBe(�[35m500�[39m) �[90m// TODO: 413?�[39m
�[90m |�[39m �[31m�[1m^�[22m�[39m
�[90m 229 |�[39m expect(
�[90m 230 |�[39m �[36mawait�[39m actionResponse�[33m.�[39mrequest()�[33m.�[39mheaderValue(�[32m'content-type'�[39m)
�[90m 231 |�[39m )�[33m.�[39mtoStartWith(�[32m'multipart/form-data'�[39m)�[0m
at Object.toBe (e2e/app-dir/actions/app-action-size-limit-invalid.test.ts:228:39)
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
mrstork
mrstork
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #3076