-
Notifications
You must be signed in to change notification settings - Fork 92
chore: remove netlify-cli deploy --build
flag
#2939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It builds by default since 21.0.0.
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
pieh
previously approved these changes
May 21, 2025
@pieh
pieh
dismissed
their stale review
May 21, 2025 08:10
Ops, we do have a fixture intentionally using older CLI and this change as-is won't work with it
"netlify-cli": "17.21.1",
Either we get rid of that fixture or this would have to be able to conditionally add --build
just for this fixture
Most used CLI version in the past 30 days is 17.17.1, so I think we still need to keep the test around
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It builds by default since 21.0.0.
This avoids printing a warning.