-
Notifications
You must be signed in to change notification settings - Fork 92
fix: expect renamed debug headers #2769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report 0%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
@serhalp
serhalp
force-pushed
the
fix/expect-renamed-debug-headers
branch
from
February 26, 2025 18:01
406279e to
ae8fab3
Compare
@serhalp
serhalp
force-pushed
the
fix/expect-renamed-debug-headers
branch
from
March 11, 2025 15:10
ae8fab3 to
7d8d339
Compare
pieh
pieh
reviewed
Mar 31, 2025
Comment on lines
+476
to
487
'debug-x-nf-edge-functions': functionsToInvoke.join(','),
'debug-x-nf-deploy-id': ctx.deployID,
'debug-x-nf-site-info': Buffer.from(
JSON.stringify({ id: ctx.siteID, name: 'Test Site', url: 'https://example.com' }),
).toString('base64'),
'x-nf-blobs-info': Buffer.from(
'debug-x-nf-blobs-info': Buffer.from(
JSON.stringify({ url: `http://${ctx.blobStoreHost}`, token: BLOB_TOKEN }),
).toString('base64'),
'x-nf-passthrough': 'passthrough',
'x-nf-passthrough-host': passthroughHost,
'x-nf-passthrough-proto': 'http:',
'debug-x-nf-passthrough': 'passthrough',
'debug-x-nf-passthrough-host': passthroughHost,
'debug-x-nf-passthrough-proto': 'http:',
'x-nf-request-id': v4(),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those probably should not change as they are used to make @netlify/edge-bundler serve work. Looking at how CLI handles those:
- https://github.com/netlify/cli/blob/e5c6a136c94f9c786c4c39a7daecddda2070473c/src/lib/edge-functions/proxy.ts#L151-L190
- https://github.com/netlify/cli/blob/e5c6a136c94f9c786c4c39a7daecddda2070473c/src/lib/edge-functions/headers.ts#L3-L20
Those should not be prefixed as they are request headers that setup edge function invocations and not response headers
Also https://github.com/netlify/edge-functions-bootstrap/blob/e49ee4a71e417c5ba91759a24f5b6ae0bd3ecc2c/src/bootstrap/headers.ts#L1-L41 is probably where those headers are used to make things work and they are not prefixed there
And Stargate link in comment above also lead to unprefixed headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The debug response headers were renamed a few weeks ago
Documentation
N/A - undocumented
Tests
🤔
Relevant links (GitHub issues, etc.) or a picture of cute animal
https://github.com/netlify/stargate/pull/2666