-
Notifications
You must be signed in to change notification settings - Fork 937
Relax the build dependency on NumPy #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not pin NumPy build dependencies to specific versions. It is no longer necessary since NumPy 1.25, as it automatically exposes "an API that is backwards compatible with the oldest NumPy version that supports the currently oldest compatible Python version" -- effectively removing the need to maintain downstream compatibility matrices. See: https://numpy.org/devdocs/dev/depending_on_numpy.html#adding-a-dependency-on-numpy
Hello @mgorny Thanks a for the contribution. The versions are pinned for now on purpose: numpy switched to manylinux_x_y build environment since version 2.3. OpenCV still uses manylinux2014. We plan to revise dependencies and build environment for the next release and update build requirements.
Well, sure — but even then, using any numpy<2.3
to build should be fine, right?
In general - yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not pin NumPy build dependencies to specific versions. It is no longer necessary since NumPy 1.25, as it automatically exposes "an API that is backwards compatible with the oldest NumPy version that supports the currently oldest compatible Python version" -- effectively removing the need to maintain downstream compatibility matrices.
See: https://numpy.org/devdocs/dev/depending_on_numpy.html#adding-a-dependency-on-numpy