-
-
Notifications
You must be signed in to change notification settings - Fork 263
Avoid duplicating user-defined enum property names#1168
Open
wileykestner wants to merge 5 commits intoopenapi-generators:main from
Open
Avoid duplicating user-defined enum property names #1168wileykestner wants to merge 5 commits intoopenapi-generators:main from
wileykestner wants to merge 5 commits intoopenapi-generators:main from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This is a naive attempt at dynamically avoiding name collisions between the generated name for a Schema object's enum property and the name of another, user-defined, Schema type.
Pros: All tests pass (at least when I run them locally with
pdm run test)Cons: I have no idea what I'm doing.
This is proposed to advance the discussion, all suggestions and guidance are most welcome.
Resolves #1167 (Allegedly)