-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[How to call function with chat model] Pretty printing applied + gpt-4o instead of gpt-5 for one failing cell #2105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tgregoir-openai
wants to merge
1
commit into
openai:main
from
tgregoir-openai:tgregoir/fix-call-functions-with-chat-models
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are mainly 3 changes in this PR:
pretty_printfunction is debugged for tool calls and is used in all other cells (defined without being used before)Motivation
Why are these changes necessary? How do they improve the cookbook?
Without this change, the cookbook does not use the defined pretty_print function (which is for now defined without being used anywhere in the notebook) and therefore displays output cells in a very raw format.
Moreover, without the change of instructions and the one-time switch to 4o, the expected outputs are not obtained in a repeatable manner.