Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: allow OAuth popups to open inside Electron webview #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pascal-sidlee wants to merge 1 commit into open-webui:main
base: main
Choose a base branch
Loading
from pascal-sidlee:fix/oauth-popup-blocked-in-webview
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/main/index.ts
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1313,7 +1313,20 @@ if (!gotTheLock) {

if (contents.getType() === 'webview') {
// ── Popups (target="_blank" links) → open in default browser ──
// OAuth popup windows (Google, Microsoft, GitHub, etc.) must open
// inside Electron so the opener page can receive the postMessage
// callback. All other popups go to the system browser.
const OAUTH_HOSTS = [
'accounts.google.com',
'login.microsoftonline.com',
'github.com/login',
'github.com/oauth',
]
contents.setWindowOpenHandler(({ url }) => {
const isOAuth = OAUTH_HOSTS.some((h) => url.includes(h))
if (isOAuth) {
return { action: 'allow' }
}
openUrl(url)
return { action: 'deny' }
})
Expand Down

AltStyle によって変換されたページ (->オリジナル) /