-
Notifications
You must be signed in to change notification settings - Fork 17
Open
Conversation
/var/run/docker.sock is mounted from the host into the docker node. Since Jenkins runs as a non-privileged user the Jenkins user must be a member of the docker group, and the docker group ID inside the node must match that of the host. Therefore run.sh is changes the GID of the docker group inside the node
Member
joshmoore
commented
Mar 18, 2019
Is the docker now being used?
Member
Author
Not in the new jobs, though apparently it's used in some of the BF jobs. If the GIDs and permissions in devspace and the host happen to be compatible this PR doesn't do anything, otherwise it should ensure the docker nodes work regardless of your user-id
Member
joshmoore
commented
Mar 19, 2019
I can see the benefit moving forward for new devspaces, but I'm concerned about how to roll out this (and perhaps some of the other changes) to a running devspace. If it's not required, and they are currently working, perhaps we hold this for 0.12 (assuming your current batch of PRs is targeting 0.11)
Member
Author
manics
commented
Mar 19, 2019
Sounds fine to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of fixes to get the docker node running:
/var/run/docker.sockis bind-mounted