-
Notifications
You must be signed in to change notification settings - Fork 94
Open
Conversation
If no year is specified, then nil is returned for: - current date July 15 in test - future months
The OFFSET based tests probably make it easier for things like "yesterday at 10am", but for DMY or MDY it is much simpler to compare it to a time.Time.
olebedev
commented
Apr 18, 2023
Owner
Hi @mvgrimes, thank you for the contribution! I will get back to you once I have some time to review the change.
In the meantime, do you know why the github actions haven't been triggered oner the change?
mvgrimes
commented
Apr 20, 2023
Author
I don't have much experience with github actions, but I wonder if it is the on: trigger. I've used/seen it as:
on:
push:
olebedev
commented
Apr 26, 2023
Owner
Oh, I think I found the issue, we would need to have trigger on the pull_request as well. I'll give it a try when I have time, but feel free to add it in your PR or please add an empty commit so we can see the tests passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In situations where the year is ambiguous (ie, 6/20 or May 12th) the package
seems to prefer to return a future date. In some situations, I think it will
default to the current year. This patch adds
WantPastto the rules.Option.When this is true it will return the prior instance of that date. It defaults
to false which preserve the current functionality.
Some examples, assuming today is July 15, 2016:
There are several strategies that could be used here: WantPast, WantFuture,
Closest, ... I've only implemented WantPast, but if there was interest then
maybe converting WantPast to an enum would make more sense.