Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updating Readme and default config file to clarify what the Org URL i...#28

Open
drnugent wants to merge 1 commit intookta:master from
drnugent:master
Open

Updating Readme and default config file to clarify what the Org URL i... #28
drnugent wants to merge 1 commit intookta:master from
drnugent:master

Conversation

@drnugent
Copy link

@drnugent drnugent commented Mar 16, 2018

...s and where to find it (this tripped me up during app creation.

...s and where to find it (this tripped me up during app creation.
export default {
oidc: {
clientId: '{clientId}',
issuer: 'https://{yourOktaDomain}.com/oauth2/default',
Copy link
Contributor

@mraible mraible Mar 16, 2018
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value you deleted is the standard syntax we use to specify this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any ideas to provide clarity for new devs on the difference between Okta Domain, dev console domain, and Org URL? I pasted my dev console domain and got a 404.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add a note like this:

TIP: The value of {yourOktaDomain} should be something like dev-123456.oktapreview. Make sure you don't include -admin in the value!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that (although it wouldn't have helped me since I didn't read the comments before filling in the values.) Would it also make sense to change the "Org URL" in the dashboard to "Your Okta Domain" for clarity?

Copy link
Contributor

mraible commented Mar 17, 2018 via email

Yes, I think this would help.
...
On Mar 16, 2018, at 17:31, Dave Nugent ***@***.***> wrote: @drnugent commented on this pull request. In custom-login/README.md: > Now place these values into the file `src/.samples.config.js` that was created for you in this project: ```javascript export default { oidc: { clientId: '{clientId}', - issuer: 'https://{yourOktaDomain}.com/oauth2/default', I can do that (although it wouldn't have helped me since I didn't read the comments before filling in the values.) Would it also make sense to change the "Org URL" in the dashboard to "Your Okta Domain" for clarity? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Copy link

hydanjan commented Aug 3, 2018

when i run npm install .samples.config.j is created by default. may i know the background of this? how is that happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mraible mraible mraible left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /