-
Notifications
You must be signed in to change notification settings - Fork 256
🌱 Add custom scopes to authorisation request#277
Open
kelvin-chappell wants to merge 4 commits intookta:master from
Open
🌱 Add custom scopes to authorisation request #277kelvin-chappell wants to merge 4 commits intookta:master from
kelvin-chappell wants to merge 4 commits intookta:master from
Conversation
This enables the Okta-hosted login app to request additional custom scopes when authorising.
Mark-McCracken
commented
Feb 2, 2023
@jaredperreault-okta can you give this a review and merge if you're happy please?
Contributor
jaredperreault-okta
commented
Feb 6, 2023
@kelvin-chappell @Mark-McCracken Do you mind explaining your use case?
Author
kelvin-chappell
commented
Feb 7, 2023
@kelvin-chappell @Mark-McCracken Do you mind explaining your use case?
At the moment, if you need to generate an access token with more than the default access scopes configured here you have to search through the code and add them to that array.
By making this a configurable environment variable we improve the dev experience and make it very easy to see, and modify, what scopes have been requested with the token.
Mark-McCracken
commented
Feb 9, 2023
@jaredperreault-okta I've been using this for the last few days, which has been helpful for getting certain kinds of access tokens. Do you need anything to get this merged?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This change enables the Okta-hosted login app to request additional custom access scopes when authorising.
Custom scopes can now be added as an optional property called
CUSTOM_SCOPESin thetestenvproperty file.Each scope is space separated.
Eg.
CUSTOM_SCOPES=read writeThese scopes are then added to the default list and included in the token request.