-
Notifications
You must be signed in to change notification settings - Fork 256
Conversation
Question: is it possible to do `!authState?.isAuthenticated` instead of `!authState && !authState.isAuthenticated`?
mraible
commented
Jun 28, 2021
It looks like this file needs to be fixed too.
Thanks for submitting this PR.
Yes, isPending is obsolete and should be removed.
Code !authState.isPending && should be removed completely, no need to change it to !authState because there are lines before that make this check:
samples-js-react/okta-hosted-login/src/Navbar.jsx
Lines 38 to 40 in 6702f99
Same for this file
@denysoblohin-okta How should I change this line? If I remove the conditionals, will a login button still be rendered?
{!authState.isPending && !authState.isAuthenticated && <Menu.Item onClick={login}>Login</Menu.Item>}
shuowu
commented
Jul 14, 2021
@mraible where did you see the issues with the code snippet above? this sample repo or other apps?
As optional chaining is a part of ES2020, you may need to config the transpiler to make it work.
mraible
commented
Aug 3, 2021
@shuowu It worked for OktaDev Schematics, which generates an app with the latest version of Create React App. oktadev/schematics@2c90198
Question: is it possible to do
!authState?.isAuthenticatedinstead of!authState && !authState.isAuthenticated?