-
Notifications
You must be signed in to change notification settings - Fork 20
Comments
Added Bronco 40 amps, cabinets and effects#21
Added Bronco 40 amps, cabinets and effects #21StillVoidingWarranties wants to merge 2 commits intooffa:20-bronco from
Conversation
include/com/IdLookup.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not comment out code, but add those values below (as with the amps).
include/effects_enum.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not change the existing listing, but append to it's end.
include/effects_enum.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, please append and do not disable.
include/effects_enum.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
src/ui/amplifier.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a Bronce comment to those so we can determine later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark: The .ui files are created by Qt Designer (usually) , so comments wont last long here. Having the comments in the source files is enough.
src/ui/effect.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bronce comment please.
test/CMakeLists.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not disable tests. It's fine for the prototype to have failing tests regarding this feature.
offa
commented
Oct 24, 2023
However it is quite messy and I broke the tests that require Mustang cabinets.
Failing tests are ok at the moment. The first step is to figure out whether the device uses a compatible protocol (it seems so 🎉), figure out the ids and getting some working prototype that can do some communication with your device.
Once these are done we can work on the actual implementation, which requires some more work. The bronco dev branch wont get merged directly, but should diff easily to master, so we can follow the changes.
offa
commented
Oct 24, 2023
Oh and thanks for your PR btw.! 👍
StillVoidingWarranties
commented
Oct 24, 2023
I first tried to just append the Bronco amps/cabs/effects but at some places the order seems to matter. Sorry, I'm not very familiar with C++ but I will clean up the code, test it manually and make another PR.
I first tried to just append the Bronco amps/cabs/effects but at some places the order seems to matter.
That should happen, but if it does you have found a bug 🐛. Let me know if you need some help here.
Sorry, I'm not very familiar with C++
Really no problem, I can help where needed. Also it might help to do the changes step by step, eg. add amps, test, add cabinets etc.
and make another PR.
You can update this PR, just push commits to your branch.
StillVoidingWarranties
commented
Oct 24, 2023
Ok, will do.
I added data for Bronco 40 amps, cabinets and effects as good as I could and it kinda works. However it is quite messy and I broke the tests that require Mustang cabinets.