-
Notifications
You must be signed in to change notification settings - Fork 317
Comments
Open
Conversation
@GalacticHypernova
GalacticHypernova
requested a review
from danielroe
as a code owner
October 29, 2025 19:02
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 7.04%. Comparing base (6022fa8) to head (dc98a9f).
Additional details and impacted files
@@ Coverage Diff @@ ## main #1995 +/- ## ===================================== Coverage 7.03% 7.04% ===================================== Files 77 77 Lines 3567 3565 -2 Branches 138 138 ===================================== Hits 251 251 + Misses 3268 3266 -2 Partials 48 48
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@GalacticHypernova
GalacticHypernova
marked this pull request as ready for review
October 29, 2025 19:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
🔗 Linked issue
#1654
❓ Type of change
📚 Description
As continuation of #1654 , and with the approach of Nuxt Image v2, I think it is time to drop the
nonceattribute.As stated in the original issue, allowing users to inject their own nonce is very dangerous, as it doesn't enforce the nonce is cryptographically secure, generated according to the spec, or unique across the app. It is much better to let dedicated security modules like Nuxt Security handle the nonce generation.
This PR is marked as breaking as it changes behavior, even though it won't actually break any projects (except maybe failing to load images in certain projects that relied on the nonce prop) because it simply voids the property.