-
Notifications
You must be signed in to change notification settings - Fork 317
Comments
feat(ipx): use alternate URL style with format as file extension#1793
Draft
feat(ipx): use alternate URL style with format as file extension #1793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #933, #584, #442
❓ Type of change
📚 Description
Implements (and depends on) the alternate URL style for IPX proposed in unjs/ipx#259
This improves prerendering of images so that the target format is respected in the generated filename, fixing issues with static hosting. For full rationale please see the description in unjs/ipx#259
The original URL style will still be used when the requested format is
auto(which is not applicable for prerendering anyway), or when no modifiers are given. Otherwise the new URL style will be used.I'm not sure whether this needs to be classed as a breaking change. It will cause different URLs to be produced with
ipxandipxStaticproviders, but that shouldn't break anything unless users are somehow relying on the old URL style.