-
Notifications
You must be signed in to change notification settings - Fork 190
test(e2e): initial commit to setup playwright with devtools package #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
antfu
commented
Oct 12, 2024
Sorry for the delay. I think it would be safer to test against the production build - I will try to improve the test setup. Thanks a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
π Linked issue
β Type of change
π Description
Adding Playwright E2E testing to the developer workflow in order to catch regressions in browsers before they land in the stable channels of major browsers.
E2E Test TODOS
pnpm playwright test)Cross-browser Test TODOS
Can be split out into its own PR. Adding Playwright without comprehensive cross-browser testing will still catch Chromium issues.
package.jsontask to execute Sauce Labs-enabled E2E tests locally