-
-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Conversation
ljharb
commented
Mar 28, 2026
Member
tap and tape have t.teardown which is like an "after" - but i'm not sure what the benefit of t.before(f) would be, since you can just f() directly.
Member
Author
what the benefit of
t.before(f)would be, since you can justf()directly
I presume you mean you could do something like
it('whatever', () => { const mocks = f(); });
f() does consolidate the code but it lacks the orchestration (resetting mocks etc).
It also makes a very common need manually repeated.
ljharb
commented
Mar 28, 2026
Member
I’m confused; there’s only one t per suite (subtests are a different one), so how would t.before(f) and f() be any different?
JakobJingleheimer
commented
Mar 28, 2026
Member
Author
Now I'm confused. Why are you talking about t.before?
ljharb
ljharb
reviewed
Mar 28, 2026
ljharb
commented
Mar 28, 2026
Member
Now that i understand the terms, this seems like a great idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.