Skip to content

Navigation Menu

Sign in
Sign up

doc(proposal): suite-level hooks - #25

Open
JakobJingleheimer wants to merge 2 commits into
main from
proposal/suite-level-hooks
Open

doc(proposal): suite-level hooks #25
JakobJingleheimer wants to merge 2 commits into
main from
proposal/suite-level-hooks

Conversation

@JakobJingleheimer

@JakobJingleheimer JakobJingleheimer commented Mar 28, 2026

Copy link
Copy Markdown
Member

No description provided.

ljharb commented Mar 28, 2026

Copy link
Copy Markdown
Member

tap and tape have t.teardown which is like an "after" - but i'm not sure what the benefit of t.before(f) would be, since you can just f() directly.

JakobJingleheimer commented Mar 28, 2026
edited
Loading

Copy link
Copy Markdown
Member Author

what the benefit of t.before(f) would be, since you can just f() directly

I presume you mean you could do something like

it('whatever', () => {
 const mocks = f();
});

f() does consolidate the code but it lacks the orchestration (resetting mocks etc).

It also makes a very common need manually repeated.

ljharb commented Mar 28, 2026

Copy link
Copy Markdown
Member

I’m confused; there’s only one t per suite (subtests are a different one), so how would t.before(f) and f() be any different?

Copy link
Copy Markdown
Member Author

Now I'm confused. Why are you talking about t.before?

Comment thread proposals/suite-level hooks.md Outdated

ljharb commented Mar 28, 2026

Copy link
Copy Markdown
Member

Now that i understand the terms, this seems like a great idea.

JakobJingleheimer reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /