@nmwsharp This PR fixes compilation/linking errors. Would appreciate your review and merge 😊

Hi! Thanks for submitting this. Pardon the delay.

ImGui_ImplOpenGL3_DestroyFontsTexture

Right now this library uses ImGui 1.91.9b, which looks to be before this change. Next time we bump the dependency I will certainly remove those, but I don't think it makes sense to remove them before bumping the dependency.

GLM_ENABLE_EXPERIMENTAL

It took me a minute to understand this. The problem is related to doing the define in CMake, which we currently do, right? Adding the define to the source directly makes sure our functions compile even if the target was defined elsewhere? I think that makes sense to me, thanks for the fix.

STB_IMAGE_STATIC

Good catch, thanks.

For now I'll remove the ImGUI change so I can merge this PR with the other two.

Hmmmm, note the build failures from the CI. I think to use STB_IMAGE_STATIC we'd need to also switch to including the implementation in every file which uses it, right?

#define STB_IMAGE_STATIC
#define STB_IMAGE_IMPLEMENTATION
#include "stb_image.h"

It's been 2 years since I had to think about C++ symbol visibility, so I might be missing something basic here.

@nmwsharp

Sorry, for the delay on my end too!

The problem with STB is indeed present. The fix I proposed here worked for me because I had a binary linking to both polyscope and stb (by including it). Therefore I had some double definition errors. When I removed STB from my dependencies (moved to wuffs), I got the no-definition linker errors. Not sure how to fix this then

Since it's been half a year since I opened this PR, I no longer have the context in my head ;( I used CPM package manager and I believe the imgui and glm were downloaded by it and had latest versions. polyscope's cmake has find_package I believe so it picked them up. I personally would encourage to use a package manager but since I am the only one with these issues (and I am using a pm), I guess it's my problem :)

The glm fix is harmless and useful though, lets only keep this one. And yes, you understood everything correctly. The define in cmake only happens if glm isn't present on the system. But if it is, then there is no define propagated to it.