Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ENH: tcksift2 #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shachafy wants to merge 3 commits into nipy:master
base: master
Choose a base branch
Loading
from shachafy:tcksift2
Open

ENH: tcksift2 #3668

shachafy wants to merge 3 commits into nipy:master from shachafy:tcksift2

Conversation

Copy link

@shachafy shachafy commented Aug 28, 2024
edited
Loading

List of changes proposed in this PR (pull-request)

An interface for MRTrix's tcksift2 as part of the overall effort to include as many as possible of the tools being used in the neuroimaging society.

Fixes #3666

Copy link

codecov bot commented Oct 6, 2024
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.51%. Comparing base (6ac81ca) to head (a49f154).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
nipype/interfaces/mrtrix3/utils.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@
## master #3668 +/- ##
==========================================
- Coverage 70.87% 70.51% -0.37% 
==========================================
 Files 1276 1277 +1 
 Lines 59238 59263 +25 
 Branches 9812 9814 +2 
==========================================
- Hits 41984 41788 -196 
- Misses 16079 16336 +257 
+ Partials 1175 1139 -36 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Example
-------

>>> import nipype.interfaces.mrtrix3 as mrt
Copy link
Member

@effigies effigies Oct 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this to work, this needs to be added to

from .utils import (
TCK2VTK,
BrainMask,
ComputeTDI,
DWIExtract,
Generate5tt,
Mesh2PVE,
MRCat,
MRConvert,
MRMath,
MRResize,
MRTransform,
SH2Amp,
SHConv,
TensorMetrics,
TransformFSLConvert,
MaskFilter,
MTNormalise,
Generate5tt2gmwmi,
)

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doctest needs to either import from fully-qualified module or the interface needs to be imported into the parent __init__.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH] Interface for tcksift2

AltStyle によって変換されたページ (->オリジナル) /