Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

FIX caching of afni allineate when out_matrix is specified #3141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
salma1601 wants to merge 6 commits into nipy:master
base: master
Choose a base branch
Loading
from salma1601:afni_allineate_out_matrix

Conversation

Copy link
Contributor

@salma1601 salma1601 commented Jan 4, 2020

Summary

Fixes #3140 .

List of changes proposed in this PR (pull-request)

added name_template, name_source and kepp_extension to out_matrix

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

Copy link
Member

satra commented Jan 5, 2020

@salma1601 - one of the doctests needs to be updated with this: -1Dmatrix_save functional_allineated.aff12

Copy link

codecov bot commented Jan 5, 2020 •
edited
Loading

Codecov Report

Merging #3141 into master will decrease coverage by 2.75%.
The diff coverage is 72.97%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #3141 +/- ##
==========================================
- Coverage 67.62% 64.86% -2.76% 
==========================================
 Files 299 299 
 Lines 39480 39493 +13 
 Branches 5220 5219 -1 
==========================================
- Hits 26698 25618 -1080 
- Misses 12070 12826 +756 
- Partials 712 1049 +337
Flag Coverage Δ
#smoketests ?
#unittests 64.86% <72.97%> (-0.03%) ⬇️
Impacted Files Coverage Δ
nipype/pipeline/plugins/tools.py 78.94% <ø> (-1.32%) ⬇️
nipype/interfaces/base/core.py 83.85% <0%> (-3.12%) ⬇️
nipype/pipeline/plugins/sgegraph.py 14.94% <0%> (ø) ⬆️
nipype/pipeline/engine/nodes.py 78.15% <100%> (-5.16%) ⬇️
nipype/pipeline/plugins/multiproc.py 78.78% <100%> (-2.47%) ⬇️
nipype/info.py 92.3% <100%> (-1.54%) ⬇️
nipype/interfaces/fsl/model.py 55.14% <100%> (-25.44%) ⬇️
nipype/pipeline/plugins/legacymultiproc.py 68.81% <100%> (+5.99%) ⬆️
nipype/__init__.py 34.37% <33.33%> (-24.36%) ⬇️
nipype/interfaces/io.py 56.41% <42.85%> (-3.27%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d68df6...85aeffc. Read the comment docs.

Copy link
Member

@salma1601 You might have an old version of black installed. I merged master and reran make specs for you. Is this ready to go otherwise?

@effigies effigies added this to the 1.5.0 milestone Feb 24, 2020
@effigies effigies modified the milestones: 1.5.0, 1.5.1 Jun 3, 2020
Copy link
Member

Just checking back in on this in the run-up to another release. Apologies for the short notice...

@effigies effigies modified the milestones: 1.5.1, future Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
future
Development

Successfully merging this pull request may close these issues.

afni Allineate caching fails when out_matrix is specified

AltStyle によって変換されたページ (->オリジナル) /