-
Notifications
You must be signed in to change notification settings - Fork 267
ENH: Allow path-like objects for tractogram load/saving #1435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jhlegarreta
wants to merge
3
commits into
nipy:master
from
jhlegarreta:AllowPathlikeTractogramLoadSave
Open
ENH: Allow path-like objects for tractogram load/saving #1435
jhlegarreta
wants to merge
3
commits into
nipy:master
from
jhlegarreta:AllowPathlikeTractogramLoadSave
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow path-like objects for tractogram load/saving. Add the corresponding tests. Change the docstrings to mark the types of the filenames as `path-like` objects instead of only `str` objects.
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.44%. Comparing base (4ee2a49) to head (04b72dc).
Additional details and impacted files
@@ Coverage Diff @@ ## master #1435 +/- ## ========================================== + Coverage 95.24% 95.44% +0.19% ========================================== Files 209 209 Lines 29782 29802 +20 Branches 3357 4478 +1121 ========================================== + Hits 28366 28444 +78 + Misses 958 925 -33 + Partials 458 433 -25
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow path-like objects for tractogram load/saving.
Add the corresponding tests.
Change the docstrings to mark the types of the filenames as
path-likeobjects instead of onlystrobjects.