-
Notifications
You must be signed in to change notification settings - Fork 267
Add ability to read/write freesurfer surface files in scanner ras #1420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sorry, you caught me just as I was heading off on vacation, and following up with nibabel has been low on my queue since getting back. Merging master and running tests.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #1420 +/- ## ========================================== - Coverage 95.44% 95.37% -0.07% ========================================== Files 209 209 Lines 29782 29788 +6 Branches 4472 4472 ========================================== - Hits 28424 28410 -14 - Misses 925 943 +18 - Partials 433 435 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't install FreeSurfer to run tests. Could you contribute the converted file to https://codeberg.org/nipy-data/nitest-freesurfer?
Previously, only freesurfer surface files with coordinates in unknown or surface ras/tkregister space could be read. Following #1419, this PR adds the ability to read surface files whose coordinates are stored in scanner ras as well.
Let me know if calling a freesurfer function via
subprocessas part of the test is a problem - but I wasn't sure how to test this feature otherwise.